[Migration] Supplier module #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
supplier
bryanchriswhite
force-pushed
the
migration/supplier-module
branch
2 times, most recently
from
d5c8df4 to
a9915b4
Compare
bryanchriswhite
force-pushed
the
migration/mock/session-module
branch
from
6363e86 to
6569969
Compare
bryanchriswhite
force-pushed
the
migration/supplier-module
branch
from
a9915b4 to
1fd29b1
Compare
11 tasks
bryanchriswhite
force-pushed
the
migration/supplier-module
branch
from
1fd29b1 to
ea17505
Compare
11 tasks
bryanchriswhite
force-pushed
the
migration/supplier-module
branch
2 times, most recently
from
356dbdc to
f891ac8
Compare
bryanchriswhite
changed the base branch from
migration/mock/session-module
to
migration/service-module
11 tasks
bryanchriswhite
force-pushed
the
migration/supplier-module
branch
from
45763f2 to
4396b69
Compare
red-0ne
requested changes
Feb 19, 2024
proto/poktroll/supplier/params.proto
Outdated
| import "amino/amino.proto"; | ||
| import "gogoproto/gogo.proto"; | ||
|
|
||
| option go_package = "github.com/pokt-network/poktroll/x/supplier/types"; |
There was a problem hiding this comment.
We should be consistent and decide to whether put go_package above or below imports
| "github.com/cosmos/cosmos-sdk/baseapp" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| simtypes "github.com/cosmos/cosmos-sdk/types/simulation" | ||
| "github.com/pokt-network/poktroll/x/supplier/keeper" |
There was a problem hiding this comment.
Suggested change
| "github.com/pokt-network/poktroll/x/supplier/keeper" | |
| "github.com/pokt-network/poktroll/x/supplier/keeper" |
x/supplier/types/errors.go
Outdated
|
|
||
| // x/supplier module sentinel errors | ||
| var ( | ||
| ErrSupplierInvalidStake = sdkerrors.Register(ModuleName, 1, "invalid supplier stake") |
There was a problem hiding this comment.
Align with the module's error numbers as low numbers may be reserved.
x/supplier/types/errors.go
Outdated
| ErrSupplierProofNotFound = sdkerrors.Register(ModuleName, 13, "proof not found") | ||
| ErrSupplierInvalidProof = sdkerrors.Register(ModuleName, 14, "invalid proof") | ||
| ErrSupplierInvalidClosestMerkleProof = sdkerrors.Register(ModuleName, 15, "invalid closest merkle proof") | ||
| ErrInvalidSigner = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message") |
There was a problem hiding this comment.
Suggested change
| ErrInvalidSigner = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message") | |
| ErrSupplierInvalidSigner = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message") |
| @@ -0,0 +1,21 @@ | |||
| package types | |||
There was a problem hiding this comment.
We should rename to message_update_params.go for consistency.
| @@ -0,0 +1 @@ | |||
| package types | |||
There was a problem hiding this comment.
Suggested change
| package types | |
| package types | |
| // This file is in place to declare the package for dynamically generated protobufs |
red-0ne
force-pushed
the
migration/supplier-module
branch
from
13fae74 to
91be215
Compare
…take:coin services
red-0ne
force-pushed
the
migration/supplier-module
branch
from
91be215 to
d5cb487
Compare
…stake:coin services
red-0ne
force-pushed
the
migration/supplier-module
branch
from
d5cb487 to
62feb1d
Compare
red-0ne
changed the base branch from
migration/service-module
to
migration/service-x-gateway
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
This branch applies the steps outlined in the migration guide notion doc under the "Module Bootstrapping > Supplier Module" section. To be merged after #385 has been approved.
Issue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist