-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Migration Review - DO NOT MERGE] Base (isolated) #380
Closed
+15,179
−111,172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
enhancement
New feature or request
on-chain
On-chain business logic
code health
Cleans up some code
labels
Feb 12, 2024
11 tasks
bryanchriswhite
force-pushed
the
migration/review/base
branch
from
February 12, 2024 07:56
3b90d1a
to
de3420f
Compare
bryanchriswhite
commented
Feb 12, 2024
) | ||
|
||
const ( | ||
AccountAddressPrefix = "pokt" | ||
Name = "pocket" | ||
Name = "poktroll" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #367 (comment)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
This PR branch reverts all module and infra related changes (module migration squashes) from #379 with the intent to serve as a "review" branch for the "chain" only. It highlights the diff between the v0.47.x and v0.50.x app/chain wiring.
Issue
Type of change
Select one or more:
Testing
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist