Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration Review - DO NOT MERGE] Base (isolated) #380

Closed
wants to merge 16 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Feb 12, 2024

Summary

Human Summary

This PR branch reverts all module and infra related changes (module migration squashes) from #379 with the intent to serve as a "review" branch for the "chain" only. It highlights the diff between the v0.47.x and v0.50.x app/chain wiring.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify): Cosmos-SDK v0.50.x migration base

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

Sorry, something went wrong.

@bryanchriswhite bryanchriswhite added enhancement New feature or request on-chain On-chain business logic code health Cleans up some code labels Feb 12, 2024
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Feb 12, 2024
@bryanchriswhite bryanchriswhite self-assigned this Feb 12, 2024
@bryanchriswhite bryanchriswhite mentioned this pull request Feb 12, 2024
11 tasks
)

const (
AccountAddressPrefix = "pokt"
Name = "pocket"
Name = "poktroll"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code enhancement New feature or request on-chain On-chain business logic
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant