Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Session module #382

Closed

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Feb 13, 2024

Summary

Human Summary

Session module migration based off of migration/supplier-x-application branch

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@red-0ne red-0ne added session Changes related to Session management code health Cleans up some code labels Feb 13, 2024
@red-0ne red-0ne added this to the Shannon TestNet milestone Feb 13, 2024
@red-0ne red-0ne self-assigned this Feb 13, 2024
@red-0ne red-0ne force-pushed the migration/session-module branch 2 times, most recently from df6da48 to b605b62 Compare February 14, 2024 20:36
@red-0ne red-0ne force-pushed the migration/supplier-x-application branch from 59cd272 to 4ff88dc Compare February 14, 2024 20:51
@red-0ne red-0ne force-pushed the migration/session-module branch 2 times, most recently from 56617f3 to 852932d Compare February 14, 2024 20:57
@red-0ne red-0ne marked this pull request as ready for review February 15, 2024 00:59
@bryanchriswhite bryanchriswhite force-pushed the migration/session-module branch from bc46342 to d84ddcf Compare February 15, 2024 19:04
@red-0ne red-0ne force-pushed the migration/session-module branch from d84ddcf to 4f65dc1 Compare February 15, 2024 22:15
@bryanchriswhite bryanchriswhite force-pushed the migration/session-module branch from 4f65dc1 to d670f36 Compare February 16, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code session Changes related to Session management
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants