[Miner] chore: scaffold create-claim message #43

bryanchriswhite · 2023-10-10T09:05:30Z

Summary

This message type is a nested dependency of the Miner via the SupplierClient.

Scaffolded MsgCreateClaim message types, handlers, etc.:
```
ignite scaffold message create-claim session_header:SessionHeader root_hash --signer SupplierAddress --module supplier
```
(NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.)
Switch MsgCreateClaim#root_hash type from string to []byte & refactor usages.

Issue

Related to:

This message type is a nested dependency of the Miner via the SupplierClient.

Type of change

Select one or more:

Testing

Run all unit tests: make go_test
Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

I have tested my changes using the available tooling
I have performed a self-review of my own code
I have commented my code, updated documentation and left TODOs throughout the codebase

proto/pocket/supplier/tx.proto

red-0ne · 2023-10-10T11:23:35Z

ignite scaffold message create-claim SupplierAddress SmstRootHash SessionId SessionNumber:uint InvalidationHeight:int --module supplier

InvalidationHeight doesn't seem to be used

bryanchriswhite · 2023-10-11T10:04:48Z

ignite scaffold message create-claim SupplierAddress SmstRootHash SessionId SessionNumber:uint InvalidationHeight:int --module supplier

InvalidationHeight doesn't seem to be used

Nice catch! 👍 I had already removed it from the code but forgot to update the scaffold command in the description.

`ignite scaffold message create-claim session_header:SessionHeader root_hash --signer SupplierAddress --module supplier` (NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.)

x/supplier/keeper/msg_server_create_claim.go

proto/pocket/supplier/tx.proto

x/supplier/client/cli/tx_create_claim.go

x/supplier/types/message_create_claim_test.go

x/supplier/keeper/msg_server_create_claim.go

The base branch was changed.

Co-authored-by: Daniel Olshansky <[email protected]>

* main: [Gateway] Scaffold the Gateway type (#57) [Gateway] Scaffold Gateway module and nothing else fix: post-merge imports [Session] Adding the Session type (#54) [WIP][Session] Adding the Relay type (#53)

x/supplier/keeper/msg_server_create_claim.go

red-0ne · 2023-10-16T12:19:53Z

x/supplier/keeper/msg_server_create_claim.go

+			- supplier address
+			- session header
+			- claim
+		2. [ ] last block height commitment; derives:


Isn't this more relevant to the proof flow?

It is, but it must be committed to already at the point. IIRC, the point was to have the client commit to some block to say, "this is the latest block I'm aware of, so please use it's block hash" (or something similar; off-by-one, etc.). Then it's up to the on-chain logic to decide if that block is too old to be used as the pseudo-random input for the msg distribution logic.

(Not to be confused with the pseudo-random input for the proof path.) 😅

@red-0ne 👆

Olshansk

LGTM.

@red-0ne I saw your comments but believe it's okay to merge it in without resolving them. I see them as guidelines for the reviewer to document and share what the next step is, but not anything set in stone.

I think it's a great example of why we need to keep these PRs small because we can potentially have a whole day of discussion on each of the bullet points, but need to keep things moving in smaller chunks.

* pokt/main: [Miner] chore: scaffold create-claim message (#43)

* pokt/main: [Service] Added the `Service` type Updated the command for unit tests in the PR template Updated PR template [Miner] chore: scaffold create-claim message (#43) [E2E] Add basics of the E2E suite (#62) [Gateway] Scaffold the unstake gateway message and nothing else (#67) [Gateway] Scaffold the gateway stake message and nothing else (#66) Add placeholder for auto-generated packages

* chore: scaffold create claim message `ignite scaffold message create-claim session_header:SessionHeader root_hash --signer SupplierAddress --module supplier` (NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.) * refactor: use `bytes` type for `MsgCreateClaim#root_hash` field * chore: add TODO comment in msg handler * chore: add TODOs Co-authored-by: Daniel Olshansky <[email protected]> --------- Co-authored-by: Daniel Olshansky <[email protected]>

bryanchriswhite added the miner Changes related to the Miner label Oct 10, 2023

bryanchriswhite added this to the Shannon TestNet milestone Oct 10, 2023

bryanchriswhite self-assigned this Oct 10, 2023

bryanchriswhite linked an issue Oct 10, 2023 that may be closed by this pull request

[Miner] Foundation for the Miner submodule #13

Closed

10 tasks

bryanchriswhite force-pushed the chore/scaffold-claim-msg branch 2 times, most recently from acfdf18 to 7f7c544 Compare October 10, 2023 09:30

bryanchriswhite marked this pull request as ready for review October 10, 2023 09:31

bryanchriswhite requested review from Olshansk and red-0ne October 10, 2023 09:31

bryanchriswhite added the supplier Changes related to the Supplier actor label Oct 10, 2023

red-0ne reviewed Oct 10, 2023

View reviewed changes

proto/pocket/supplier/tx.proto Outdated Show resolved Hide resolved

proto/pocket/supplier/tx.proto Outdated Show resolved Hide resolved

bryanchriswhite marked this pull request as draft October 11, 2023 10:40

bryanchriswhite added 2 commits October 11, 2023 23:28

refactor: use bytes type for MsgCreateClaim#root_hash field

d6ce316

bryanchriswhite force-pushed the chore/scaffold-claim-msg branch from 7f7c544 to d6ce316 Compare October 11, 2023 21:31

bryanchriswhite changed the base branch from main to refactor/shared-supplier-type October 11, 2023 21:31

bryanchriswhite marked this pull request as ready for review October 11, 2023 21:32

bryanchriswhite requested a review from red-0ne October 11, 2023 21:32

bryanchriswhite commented Oct 11, 2023

View reviewed changes

x/supplier/keeper/msg_server_create_claim.go Outdated Show resolved Hide resolved

chore: add TODO comment in msg handler

44b421f

Olshansk previously approved these changes Oct 13, 2023

View reviewed changes

proto/pocket/supplier/tx.proto Show resolved Hide resolved

x/supplier/client/cli/tx_create_claim.go Show resolved Hide resolved

x/supplier/types/message_create_claim_test.go Show resolved Hide resolved

x/supplier/keeper/msg_server_create_claim.go Show resolved Hide resolved

Base automatically changed from refactor/shared-supplier-type to main October 13, 2023 06:02

chore: add TODOs

20c6373

Co-authored-by: Daniel Olshansky <[email protected]>

bryanchriswhite force-pushed the chore/scaffold-claim-msg branch from a68e595 to 20c6373 Compare October 13, 2023 14:35

Merge branch 'main' into chore/scaffold-claim-msg

bcf742d

* main: [Gateway] Scaffold the Gateway type (#57) [Gateway] Scaffold Gateway module and nothing else fix: post-merge imports [Session] Adding the Session type (#54) [WIP][Session] Adding the Relay type (#53)

bryanchriswhite requested a review from Olshansk October 13, 2023 14:51

red-0ne reviewed Oct 16, 2023

View reviewed changes

Olshansk approved these changes Oct 16, 2023

View reviewed changes

Merge branch 'main' into chore/scaffold-claim-msg

daeaec3

bryanchriswhite merged commit ab0a1f1 into main Oct 17, 2023
3 checks passed

bryanchriswhite added a commit that referenced this pull request Oct 17, 2023

Merge remote-tracking branch 'pokt/main' into chore/scaffold-proof-msg

bf0b0fe

* pokt/main: [Miner] chore: scaffold create-claim message (#43)

bryanchriswhite deleted the chore/scaffold-claim-msg branch October 23, 2023 20:24

Olshansk mentioned this pull request Nov 3, 2023

[Protocol] MVP implementation off the on-chain CreateClaim message handling #140

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Miner] chore: scaffold create-claim message #43

[Miner] chore: scaffold create-claim message #43

bryanchriswhite commented Oct 10, 2023 •

edited

Loading

red-0ne commented Oct 10, 2023

bryanchriswhite commented Oct 11, 2023

red-0ne Oct 16, 2023

bryanchriswhite Oct 18, 2023 •

edited

Loading

bryanchriswhite Oct 18, 2023

bryanchriswhite Oct 18, 2023

Olshansk left a comment

[Miner] chore: scaffold create-claim message #43

[Miner] chore: scaffold create-claim message #43

Conversation

bryanchriswhite commented Oct 10, 2023 • edited Loading

Summary

Issue

Type of change

Testing

Sanity Checklist

red-0ne commented Oct 10, 2023

bryanchriswhite commented Oct 11, 2023

red-0ne Oct 16, 2023

Choose a reason for hiding this comment

bryanchriswhite Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

bryanchriswhite Oct 18, 2023

Choose a reason for hiding this comment

bryanchriswhite Oct 18, 2023

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

bryanchriswhite commented Oct 10, 2023 •

edited

Loading

bryanchriswhite Oct 18, 2023 •

edited

Loading