Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Miner, Supplier] chore: scaffold submit-proof message #44

Merged
merged 12 commits into from
Oct 18, 2023
Merged

[Miner, Supplier] chore: scaffold submit-proof message #44

merged 12 commits into from
Oct 18, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 10, 2023 •
edited
Loading

Summary

This message type is a nested dependency of the Miner via the SupplierClient.

  • Scaffolded MsgSubmitProof message types, handlers, etc.:

    ignite scaffold message submit-proof session_header:SessionHeader proof --signer supplier_address --module supplier

    (NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.)

  • Switch MsgSubmitProof#proof field type from string to []byte & refactor usages.

Issue

Related to:

This message type is a nested dependency of the Miner via the SupplierClient.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added supplier Changes related to the Supplier actor miner Changes related to the Miner labels Oct 10, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Oct 10, 2023
@bryanchriswhite bryanchriswhite self-assigned this Oct 10, 2023
@bryanchriswhite bryanchriswhite linked an issue Oct 10, 2023 that may be closed by this pull request
[Miner] Foundation for the Miner submodule #13
Closed
10 tasks
@bryanchriswhite bryanchriswhite force-pushed the chore/scaffold-proof-msg branch from 7eb87cd to 0258908 Compare October 10, 2023 11:00
@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 10, 2023 11:01
@bryanchriswhite bryanchriswhite marked this pull request as draft October 11, 2023 10:40
@Olshansk
Copy link
Member

@bryanchriswhite Discussed offline, but do you still plan to scaffold an empty message and add the params in a followup PR?

@bryanchriswhite bryanchriswhite force-pushed the chore/scaffold-proof-msg branch from 0258908 to 45dde3e Compare October 11, 2023 20:58
@bryanchriswhite bryanchriswhite changed the base branch from main to refactor/shared-supplier-type October 11, 2023 20:59
@bryanchriswhite
chore: scaffold submit proof message
1e948fa 
ignite scaffold message submit-proof session_header:SessionHeader proof --signer supplier_address --module supplier
(NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.)
@bryanchriswhite
refactor: use bytes type for MsgSubmitProof#Proof field
17ad11a
@bryanchriswhite bryanchriswhite force-pushed the chore/scaffold-proof-msg branch from 45dde3e to 17ad11a Compare October 11, 2023 21:00
@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 11, 2023 21:01
Olshansk
Olshansk requested changes Oct 13, 2023
View reviewed changes
proto/pocket/supplier/tx.proto Show resolved Hide resolved
x/supplier/client/cli/tx_submit_proof.go Show resolved Hide resolved
x/supplier/client/cli/tx_submit_proof.go Show resolved Hide resolved
x/supplier/types/message_submit_proof_test.go Show resolved Hide resolved
Base automatically changed from refactor/shared-supplier-type to main October 13, 2023 06:02
@bryanchriswhite
chore: add TODOs
1b0f739 
(cherry picked from commit b158071f551e9caea2408dec2883d0b301a2c541)
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/scaffold-proof-msg
036c986 
* pokt/main:
  [Gateway] Scaffold the Gateway type (#57)
  [Gateway] Scaffold Gateway module and nothing else
  fix: post-merge imports
  [Session] Adding the Session type (#54)
  [WIP][Session] Adding the Relay type (#53)
Olshansk
Olshansk previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a request for one more comment.

proto/pocket/supplier/tx.proto Show resolved Hide resolved
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/scaffold-proof-msg
bf0b0fe 
* pokt/main:
  [Miner] chore: scaffold create-claim message (#43)
Olshansk
Olshansk requested changes Oct 17, 2023
View reviewed changes
proto/pocket/supplier/tx.proto Outdated Show resolved Hide resolved
proto/pocket/supplier/tx.proto Show resolved Hide resolved
proto/pocket/supplier/tx.proto Outdated Show resolved Hide resolved
@bryanchriswhite
chore: review feedback improvements
864f49c
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/scaffold-proof-msg
3ab5595 
* pokt/main:
  [Service] Added the `Service` type
  Updated the command for unit tests in the PR template
  Updated PR template
@bryanchriswhite
trigger CI
1845e65
@bryanchriswhite bryanchriswhite merged commit cecace6 into main Oct 18, 2023
3 checks passed
bryanchriswhite added a commit that referenced this pull request Oct 19, 2023
@bryanchriswhite
Merge branch 'main' into feat/observable
ce3b055 
* main:
  [Miner, Supplier] chore: scaffold submit-proof message (#44)
  [Application] Implement MsgUnstakeApplication & Add Extensive Tests (#72)
  [Gateway] Implement UnstakeGateway message and add Tests (#75)
  [Gateway] Implement StakeGateway Message and Add Tests (#68)
  [Application] Implement MsgStakeApplication & Add Extensive Tests (#59)
  [CI] fix: run `make go_mockgen` step (#63)
bryanchriswhite added a commit that referenced this pull request Oct 19, 2023
@bryanchriswhite
Merge branch 'feat/observable' into merge/observable_x_supplier-msgs
69544fb 
* feat/observable:
  chore: last minute improvements
  chore: review improvements
  chore: improve comment
  chore: misc. review feedback improvements
  chore: improve comments
  refactor: rename `Observable#Close()` to `#UnsubscribeAll()`
  chore: improve comments
  chore: improve comments
  chore: cleanup, simplification, review improvements
  [Miner, Supplier] chore: scaffold submit-proof message (#44)
  [Application] Implement MsgUnstakeApplication & Add Extensive Tests (#72)
  [Gateway] Implement UnstakeGateway message and add Tests (#75)
  [Gateway] Implement StakeGateway Message and Add Tests (#68)
  [Application] Implement MsgStakeApplication & Add Extensive Tests (#59)
  [CI] fix: run `make go_mockgen` step (#63)
@bryanchriswhite bryanchriswhite deleted the chore/scaffold-proof-msg branch October 23, 2023 20:24
@Olshansk Olshansk mentioned this pull request Nov 3, 2023
Closed
8 tasks
okdas pushed a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite @Olshansk
[Miner, Supplier] chore: scaffold submit-proof message (#44)
65ffa44 
* chore: scaffold submit proof message

ignite scaffold message submit-proof session_header:SessionHeader proof --signer supplier_address --module supplier
(NB: generated a temporary SessionHeader duplicate in the supplier module so the above would work; subsequently, removed and updated protobuf import and usage.)

* refactor: use `bytes` type for `MsgSubmitProof#Proof` field

* chore:  add TODO comment in msg handler

* chore: add TODOs

(cherry picked from commit b158071f551e9caea2408dec2883d0b301a2c541)

* chore: add comment to `MsgSubmitProof#proof` field

Co-authored-by: Olshansk <[email protected]>

* chore: review feedback improvements

* trigger CI

---------

Co-authored-by: Olshansk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

@h5law h5law Awaiting requested review from h5law

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@bryanchriswhite bryanchriswhite

Labels
miner Changes related to the Miner supplier Changes related to the Supplier actor
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.

[Miner] Foundation for the Miner submodule
4 participants
@bryanchriswhite @Olshansk @red-0ne @h5law