Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supplier] Scaffolded the UnstakeSupplier message and nothing else #50

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Oct 10, 2023

Summary

Ran the following command:

ignite scaffold message unstake-supplier --module supplier --signer address --yes

Summary generated by Reviewpad on 10 Oct 23 21:22 UTC

This pull request includes the following changes:

  1. In docs/static/openapi.yml, there are changes related to the pocket.supplier.MsgStakeSupplierResponse and the addition of the pocket.supplier.MsgUnstakeSupplierResponse type.

  2. The file proto/pocket/supplier/tx.proto has been modified to add the MsgUnstakeSupplier message and the corresponding response type.

  3. In x/supplier/client/cli/tx.go, the CmdUnstakeSupplier command has been added.

  4. The file x/supplier/client/cli/tx_unstake_supplier.go has been added to implement the unstake-supplier command.

  5. The file x/supplier/keeper/msg_server_unstake_supplier.go has been added to handle the MsgUnstakeSupplier message.

  6. In x/supplier/module_simulation.go, there are changes related to the simulation of the MsgUnstakeSupplier operation.

  7. The file x/supplier/simulation/unstake_supplier.go has been added to implement the simulation of the MsgUnstakeSupplier operation.

  8. Changes have been made in x/supplier/types/codec.go to register the MsgUnstakeSupplier message and response type.

  9. The file x/supplier/types/message_unstake_supplier.go has been added to implement the MsgUnstakeSupplier message.

  10. The file x/supplier/types/message_unstake_supplier_test.go has been added to test the validation of the MsgUnstakeSupplier message.

Please review the diff for more details.

Issue

Part of #7

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all_unit
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk added the supplier Changes related to the Supplier actor label Oct 10, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Oct 10, 2023
@Olshansk Olshansk self-assigned this Oct 10, 2023
@@ -75350,7 +75350,11 @@ definitions:
description: params holds all the parameters of this module.
type: object
description: QueryParamsResponse is response type for the Query/Params RPC method.
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove git conflict marker

@Olshansk Olshansk merged commit 3092d6b into main Oct 10, 2023
3 checks passed
@Olshansk Olshansk deleted the issues/7/supplier_unstake_base branch October 10, 2023 21:32
bryanchriswhite added a commit that referenced this pull request Oct 13, 2023
* pokt/main: (25 commits)
  [Gateway] Scaffold the Gateway type (#57)
  [Gateway] Scaffold Gateway module and nothing else
  fix: post-merge imports
  [Session] Adding the Session type (#54)
  [WIP][Session] Adding the Relay type (#53)
  refactor: move `Supplier` protobuf type to `pocket.shared` package (x/shared/types/)
  Reply to final comments and make things compile
  WIP - Adding an alternative session implementation
  Updated comments
  Regenerate openapi.yml
  Updated session.proto
  Added session examples from all the places
  Ran ignite scaffold type session --module session --yes
  [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#50)
  [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#52)
  [Application] Scaffolded the Application type (without CRUD messages) and nothing else (#47)
  [Supplier] Scaffolded the Supplier type (without CRUD messages) and nothing else (#48)
  [Service] Just scaffold the Service module without any params (#37)
  [Supplier] Scaffolded the StakeSupplier message and nothing else (#51)
  [Supplier] Scaffolded the StakeSupplier message and nothing else (#49)
  ...
okdas pushed a commit that referenced this pull request Nov 14, 2024
Ran the following command:

```
ignite scaffold message unstake-supplier --module supplier --signer address --yes
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
supplier Changes related to the Supplier actor
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants