-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Supplier] Scaffolded the UnstakeSupplier message and nothing else #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
previously approved these changes
Oct 10, 2023
red-0ne
reviewed
Oct 10, 2023
docs/static/openapi.yml
Outdated
@@ -75350,7 +75350,11 @@ definitions: | |||
description: params holds all the parameters of this module. | |||
type: object | |||
description: QueryParamsResponse is response type for the Query/Params RPC method. | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove git conflict marker
bryanchriswhite
previously approved these changes
Oct 10, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Oct 13, 2023
* pokt/main: (25 commits) [Gateway] Scaffold the Gateway type (#57) [Gateway] Scaffold Gateway module and nothing else fix: post-merge imports [Session] Adding the Session type (#54) [WIP][Session] Adding the Relay type (#53) refactor: move `Supplier` protobuf type to `pocket.shared` package (x/shared/types/) Reply to final comments and make things compile WIP - Adding an alternative session implementation Updated comments Regenerate openapi.yml Updated session.proto Added session examples from all the places Ran ignite scaffold type session --module session --yes [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#50) [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#52) [Application] Scaffolded the Application type (without CRUD messages) and nothing else (#47) [Supplier] Scaffolded the Supplier type (without CRUD messages) and nothing else (#48) [Service] Just scaffold the Service module without any params (#37) [Supplier] Scaffolded the StakeSupplier message and nothing else (#51) [Supplier] Scaffolded the StakeSupplier message and nothing else (#49) ...
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Ran the following command: ``` ignite scaffold message unstake-supplier --module supplier --signer address --yes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran the following command:
Summary generated by Reviewpad on 10 Oct 23 21:22 UTC
This pull request includes the following changes:
In
docs/static/openapi.yml
, there are changes related to thepocket.supplier.MsgStakeSupplierResponse
and the addition of thepocket.supplier.MsgUnstakeSupplierResponse
type.The file
proto/pocket/supplier/tx.proto
has been modified to add theMsgUnstakeSupplier
message and the corresponding response type.In
x/supplier/client/cli/tx.go
, theCmdUnstakeSupplier
command has been added.The file
x/supplier/client/cli/tx_unstake_supplier.go
has been added to implement theunstake-supplier
command.The file
x/supplier/keeper/msg_server_unstake_supplier.go
has been added to handle theMsgUnstakeSupplier
message.In
x/supplier/module_simulation.go
, there are changes related to the simulation of theMsgUnstakeSupplier
operation.The file
x/supplier/simulation/unstake_supplier.go
has been added to implement the simulation of theMsgUnstakeSupplier
operation.Changes have been made in
x/supplier/types/codec.go
to register theMsgUnstakeSupplier
message and response type.The file
x/supplier/types/message_unstake_supplier.go
has been added to implement theMsgUnstakeSupplier
message.The file
x/supplier/types/message_unstake_supplier_test.go
has been added to test the validation of theMsgUnstakeSupplier
message.Please review the diff for more details.
Issue
Part of #7
Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist