Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supplier] Scaffolded the StakeApplication message and nothing else #51

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[Supplier] Scaffolded the StakeApplication message and nothing else #51

merged 1 commit into from
Oct 10, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Oct 10, 2023 •
edited by reviewpad bot
Loading

Summary

Ran the following command

ignite scaffold message stake-application --module application --signer address --yes

Summary generated by Reviewpad on 10 Oct 23 20:42 UTC

This pull request includes the following changes:

  • In the docs/static/openapi.yml file, a new object type pocket.application.MsgStakeApplicationResponse is added.
  • In the proto/pocket/application/tx.proto file, a new service RPC StakeApplication and message types MsgStakeApplication and MsgStakeApplicationResponse are added.
  • In the x/application/client/cli/tx.go file, a new command stake-application and its corresponding implementation are added.
  • In the x/application/client/cli/tx_stake_application.go file, a new file with the implementation of the stake-application command is added.
  • In the x/application/keeper/msg_server_stake_application.go file, the implementation of the StakeApplication method is added.
  • In the x/application/module_simulation.go file, simulation-related configurations and operations are added for the MsgStakeApplication message type.
  • In the x/application/simulation/stake_application.go file, the simulation implementation for the MsgStakeApplication message type is added.
  • In the x/application/types/codec.go file, the MsgStakeApplication message type is registered for encoding and decoding.
  • In the x/application/types/message_stake_application.go file, the implementation of the MsgStakeApplication message type is added.
  • In the x/application/types/message_stake_application_test.go file, the tests for the MsgStakeApplication message type are added.

Issue

Part of #8

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all_unit
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk added the application Changes related to the Application actor label Oct 10, 2023
@Olshansk Olshansk self-assigned this Oct 10, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Oct 10, 2023
@Olshansk Olshansk merged commit 4fe69ad into main Oct 10, 2023
3 checks passed
@Olshansk Olshansk deleted the issues/8/application_stake_base branch October 10, 2023 20:52
bryanchriswhite added a commit that referenced this pull request Oct 13, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into feat/observable
c3b8cea 
* pokt/main: (25 commits)
  [Gateway] Scaffold the Gateway type (#57)
  [Gateway] Scaffold Gateway module and nothing else
  fix: post-merge imports
  [Session] Adding the Session type (#54)
  [WIP][Session] Adding the Relay type (#53)
  refactor: move `Supplier` protobuf type to `pocket.shared` package (x/shared/types/)
  Reply to final comments and make things compile
  WIP - Adding an alternative session implementation
  Updated comments
  Regenerate openapi.yml
  Updated session.proto
  Added session examples from all the places
  Ran ignite scaffold type session --module session --yes
  [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#50)
  [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#52)
  [Application] Scaffolded the Application type (without CRUD messages) and nothing else (#47)
  [Supplier] Scaffolded the Supplier type (without CRUD messages) and nothing else (#48)
  [Service] Just scaffold the Service module without any params (#37)
  [Supplier] Scaffolded the StakeSupplier message and nothing else (#51)
  [Supplier] Scaffolded the StakeSupplier message and nothing else (#49)
  ...
@bryanchriswhite bryanchriswhite changed the title [Supplier] Scaffolded the StakeSupplier message and nothing else [Supplier] Scaffolded the StakeApplication message and nothing else Oct 16, 2023
okdas pushed a commit that referenced this pull request Nov 14, 2024
@Olshansk
[Supplier] Scaffolded the StakeSupplier message and nothing else (#51)
4c5b0e1 
Ran the following command

```bash
ignite scaffold message stake-application --module application --signer address --yes
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@Olshansk Olshansk

Labels
application Changes related to the Application actor
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
2 participants
@Olshansk @bryanchriswhite