-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Session] Adding the Relay type #53
Conversation
@bryanchriswhite @red-0ne This isn't ready to be merged in, but I think it's close and would really appreciate your feedback on the first iteration of its design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we could have a better categorization of the different properties that would allow for more extensibility too.
I propose something along the following:
RelayRequestMetadata {
session_header
signature
}
RelayRequest {
RelayRequestMetadata meta
oneof payload {
JSONRPCRequestPayload ...
RESTRequestPayload ...
}
}
RelayResponseMetadata {
session_header
supplier_signature
}
RelayResponse {
RelayResponseMetadata meta
oneof payload {
JSONRPCResponsePayload ...
RESTResponsePayload ...
}
}
Then each payload would be in terms of request/reply x RPCType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels great! Just left a question regarding JSONRPCResponsePayload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
* pokt/main: (25 commits) [Gateway] Scaffold the Gateway type (#57) [Gateway] Scaffold Gateway module and nothing else fix: post-merge imports [Session] Adding the Session type (#54) [WIP][Session] Adding the Relay type (#53) refactor: move `Supplier` protobuf type to `pocket.shared` package (x/shared/types/) Reply to final comments and make things compile WIP - Adding an alternative session implementation Updated comments Regenerate openapi.yml Updated session.proto Added session examples from all the places Ran ignite scaffold type session --module session --yes [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#50) [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#52) [Application] Scaffolded the Application type (without CRUD messages) and nothing else (#47) [Supplier] Scaffolded the Supplier type (without CRUD messages) and nothing else (#48) [Service] Just scaffold the Service module without any params (#37) [Supplier] Scaffolded the StakeSupplier message and nothing else (#51) [Supplier] Scaffolded the StakeSupplier message and nothing else (#49) ...
Scaffolding and customizing the first version of the `Relay` type.
Summary
Scaffolding & adding the
Relay
typeSummary generated by Reviewpad on 11 Oct 23 18:07 UTC
This pull request includes the following changes:
google.golang.org/genproto
has been removed from the require section.google.golang.org/genproto
has been added to the require section.relay.proto
has been added in theproto/pocket/service
directory. This file contains protobuf message definitions related to relaying requests and responses.relay.proto
file imports other protobuf files and defines message structures for relay requests, relay responses, and their metadata. It also includes definitions for JSON-RPC request and response payloads, REST request payloads, and REST response payloads.Please review these changes and provide any necessary feedback.
Issue
Part of #10
Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist