[Application] Refactor app module to fetch on-chain params #555

bryanchriswhite · 2024-05-28T07:30:53Z

Summary

Refactor the application module to remove all usage of the NumBlocksPerSession stand-in constant, in favor of fetching the on-chain param. This involves adding the shared module as a dependency.

Issue

[Protocol] Add a NumBlocksPerSession governance parameter #517

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

Unit Tests: make go_develop_and_test
LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

Co-authored-by: Daniel Olshansky <[email protected]>

…n E2E test

…thod

…elayerSessionsManager

…r method

…ate args

ellipsis-dev · 2024-05-28T10:00:14Z

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at [email protected]

Olshansk

Will re-review the entire PR on the next round but my main feedback is:

s/queryHeight/blockHeight/
s/GetDefaultX/GetXForDefaultParams

Lmk wyt

x/shared/session.go

x/application/types/expected_keepers.go

x/shared/session.go

x/application/keeper/msg_server_undelegate_from_gateway_test.go

…`WithDefaultParams`

…ues/517/refactor/app-module * issues/517/refactor/session-params_relayminer: [Relay Mining] Relay Mining math helpers (#549) [Relay Mining] Scaffold the RelayMiningDifficulty type (#548)

…-module * pokt/main: [Relayminer] Query for on-chain session param `num_blocks_per_session` (#538)

Olshansk

Optional comment updates

x/shared/session.go

Co-authored-by: Daniel Olshansky <[email protected]>

…g-client * pokt/main: [Application] Refactor app module to fetch on-chain params (#555) [Relayminer] Fix: relayminer on time sessions (#550)

…ssues/516/feat/claim-window-close-offset-blocks * issues/516/feat/claim-window-open-offset-blocks: test: ValidateClaimWindowOpenOffsetBlocks [On-chain] chore: add single param updates to `shared` module (#560) Empty commit [Code Health] chore: resolve & cleanup outstanding `TODO_TECHDEBT(#517)` comments (#559) [Session Module] refactor: session module fetches on-chain params (#557) [Ring Client] refactor: ring client to use on-chain params (#556) [LoadTest] Switch funding account to key name instead of address (#562) [Application] Refactor app module to fetch on-chain params (#555) [Relayminer] Fix: relayminer on time sessions (#550) Empty commit

…issues/516/refactor/relayminer * issues/516/feat/claim-window-close-offset-blocks: test: ValidateClaimWindowCloseOffsetBlocks test: ValidateClaimWindowOpenOffsetBlocks [On-chain] chore: add single param updates to `shared` module (#560) Empty commit [Code Health] chore: resolve & cleanup outstanding `TODO_TECHDEBT(#517)` comments (#559) [Session Module] refactor: session module fetches on-chain params (#557) [Ring Client] refactor: ring client to use on-chain params (#556) [LoadTest] Switch funding account to key name instead of address (#562) [Application] Refactor app module to fetch on-chain params (#555) [Relayminer] Fix: relayminer on time sessions (#550) Empty commit

Co-authored-by: Daniel Olshansky <[email protected]>

bryanchriswhite and others added 30 commits May 15, 2024 14:10

feat: add num_blocks_per_session session module param

a3d3d17

feat: add make target to update all session params

99455d5

chore: use default param values in param update msgs

05e631a

Empty commit

bf3bff3

fixup! feat: add num_blocks_per_session session module param

3aa53ec

test: add coverage for sessiontypes.Params#ValidateNumBlocksPerSession()

d7a04dc

fix: #ValidateNumBlocksPerSession()

56ae9a8

chore: review feedback improvements

b291bc1

Co-authored-by: Daniel Olshansky <[email protected]>

Merge branch 'main' into issues/517/param-num_blocks_per_session

e9afc4c

refactor: rename param name vars

40e1e7f

fix: unit tests

2c33381

Merge branch 'main' into issues/517/param-num_blocks_per_session

9597876

Merge branch 'main' into issues/517/param-num_blocks_per_session

1eae173

Empty commit

86e114d

Empty commit

eaf5f15

Empty commit

a757d5a

chore: add "unauthorized" account to config.yml instead of creating i…

6c6ec62

…n E2E test

chore: add client.SessionQueryClient#GetParams interface method

638f0c9

chore: add ErrQuerySessionParams

a6667eb

feat: implement sessionQuerier#GetParams()

42a63f1

chore: add SessionQueryClient#GetSessionGracePeriodCount interface me…

16dafd3

…thod

feat: implement sessionQuerier#GetSessionGracePeriodBlockCount()

48526a0

chore: add sessionQueryClient field to relayerSessionsManager

3d59a5d

refactor: IsWithinGracePeriod from a static function to a method on r…

c24ba01

…elayerSessionsManager

chore: add IsWithinGracePeriod method to relayerProxy

b23d9d8

docs: update relayerProxy#sessoinQuerier godoc comment

43682ed

refactor: move duplicated #IsWithinGracePeriod methods to sessionQuerier

7b64b2b

chore: add SessionQueryClient#IsPastGracePeriod() interface method

5c42c06

refactor: IsPastGracePeriod from a static function to a sessionQuerie…

264edb2

…r method

refactor: factor static functions back out to session pkg w/ appropri…

d75e5ae

…ate args

chore: self-review improvements

3546ad3

bryanchriswhite marked this pull request as ready for review May 28, 2024 10:00

bryanchriswhite requested review from Olshansk and red-0ne May 28, 2024 10:00

bryanchriswhite linked an issue May 28, 2024 that may be closed by this pull request

[Protocol] Add a NumBlocksPerSession governance parameter #517

Closed

10 tasks

bryanchriswhite modified the milestones: Shannon Beta TestNet Launch, Shannon Alpha TestNet Launch May 28, 2024

bryanchriswhite mentioned this pull request May 28, 2024

[Protocol] Add a NumBlocksPerSession governance parameter #517

Closed

10 tasks

Olshansk requested changes May 28, 2024

View reviewed changes

bryanchriswhite added 3 commits May 29, 2024 09:04

Merge branch 'main' into issues/517/refactor/session-params_relayminer

a0a23b7

refactor: rename methods which use default shared params with suffix …

a58e553

…`WithDefaultParams`

chore: udpate comments

a3b7abb

bryanchriswhite mentioned this pull request May 29, 2024

[Relayminer] Query for on-chain session param num_blocks_per_session #538

Merged

14 tasks

bryanchriswhite added 2 commits May 29, 2024 09:53

Merge branch 'issues/517/refactor/session-params_relayminer' into iss…

6ec7f00

…ues/517/refactor/app-module * issues/517/refactor/session-params_relayminer: [Relay Mining] Relay Mining math helpers (#549) [Relay Mining] Scaffold the RelayMiningDifficulty type (#548)

Merge remote-tracking branch 'pokt/main' into issues/517/refactor/app…

8ce12f5

…-module * pokt/main: [Relayminer] Query for on-chain session param `num_blocks_per_session` (#538)

bryanchriswhite changed the base branch from issues/517/refactor/session-params_relayminer to main May 29, 2024 07:58

bryanchriswhite requested a review from Olshansk May 29, 2024 08:00

bryanchriswhite and others added 2 commits May 29, 2024 10:16

Merge branch 'main' into issues/517/refactor/app-module

15658c8

Merge branch 'main' into issues/517/refactor/app-module

56d2bfc

Olshansk approved these changes May 30, 2024

View reviewed changes

x/shared/session.go Outdated Show resolved Hide resolved

x/shared/session.go Outdated Show resolved Hide resolved

x/shared/session.go Outdated Show resolved Hide resolved

x/shared/session.go Outdated Show resolved Hide resolved

bryanchriswhite and others added 2 commits May 30, 2024 08:21

chore: review feedback improvements

661219b

Co-authored-by: Daniel Olshansky <[email protected]>

Empty commit

3c47a24

bryanchriswhite merged commit e83b902 into main May 30, 2024
10 checks passed

This comment was marked as outdated.

Sign in to view

bryanchriswhite deleted the issues/517/refactor/app-module branch May 30, 2024 10:53

okdas pushed a commit that referenced this pull request Nov 14, 2024

[Application] Refactor app module to fetch on-chain params (#555)

df338b8

Co-authored-by: Daniel Olshansky <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Application] Refactor app module to fetch on-chain params #555

[Application] Refactor app module to fetch on-chain params #555

bryanchriswhite commented May 28, 2024 •

edited

Loading

ellipsis-dev bot commented May 28, 2024

Olshansk left a comment

Olshansk left a comment

This comment was marked as outdated.

[Application] Refactor app module to fetch on-chain params #555

[Application] Refactor app module to fetch on-chain params #555

Conversation

bryanchriswhite commented May 28, 2024 • edited Loading

Summary

Issue

Type of change

Testing

Sanity Checklist

ellipsis-dev bot commented May 28, 2024

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

bryanchriswhite commented May 28, 2024 •

edited

Loading