Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gateway] Scaffold initial module #56

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[Gateway] Scaffold initial module #56

merged 2 commits into from
Oct 12, 2023

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Oct 11, 2023

Summary

Run ignite scaffold module gateway --dep bank,account

Summary generated by Reviewpad on 11 Oct 23 16:19 UTC

This pull request introduces several changes across multiple files.

  1. The file proto/pocket/gateway/tx.proto has been added, defining a new service called Msg and specifying the Go package as pocket/x/gateway/types.
  2. The file genesis_test.go has been added to the gateway package. It includes test functions related to the genesis state and export of the gateway module.
  3. The file params.proto has been added to the proto/pocket/gateway directory. It defines the Params message and imports the gogoproto/gogo.proto file. The Go package is set to pocket/x/gateway/types.
  4. The file params.go has been added to the x/gateway/types directory. It contains code related to parameter handling and validation for the gateway module.
  5. The file module.go has been added. It defines the gateway package, implements various interfaces, and includes functions for module initialization and event handling.
  6. The file x/gateway/client/cli/query.go has been added. It contains the CLI query commands for the gateway module.
  7. The file msg_server.go has been added to the x/gateway/keeper package. It defines a struct called msgServer and implements the NewMsgServerImpl function.
  8. The file helpers.go has been added to the simulation package in the x/gateway directory. It defines a function called FindAccount for finding a specific address from the account list.
  9. The file params.go has been added to the x/gateway/keeper package. It contains functions for handling parameters in the gateway module.
  10. The file app.go has been modified to include changes related to the gateway module.
  11. The file testutil/keeper/gateway.go has been added. It includes a function for creating a keeper for the Pocket Gateway module for testing purposes.
  12. The file params.go has been added to the x/gateway/client/cli package. It contains a command implementation for querying and displaying the parameters of the gateway module.
  13. The file codec.go has been added to the x/gateway/types package. It includes functions for registering codecs and interfaces.
  14. The file query_params.go has been added to the x/gateway/client/cli package. It contains a command implementation for querying and displaying the parameters of the gateway module.
  15. The file keeper.go has been added. It defines a Keeper struct and implements its methods.
  16. The file msg_server_test.go has been added. It includes test functions related to the message server.
  17. The file query_params_test.go has been added to the x/gateway/keeper package. It contains a test function for querying the parameters of the keeper.
  18. The file query.go has been modified to include changes related to the gateway module.
  19. The file params_test.go has been added to the x/gateway/keeper package. It contains a test function for the GetParams function.
  20. The file genesis.go has been added to the x/gateway package. It includes functions for initializing and exporting the module's genesis state.
  21. The file module_simulation.go has been added to the x/gateway directory. It contains code related to the gateway module for simulation purposes.

Please review the changes and provide feedback accordingly.

Issue

Fixes (in-part) 19

[ ] A single PR that uses ignite to scaffold the gateway module

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all_unit
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@h5law h5law added gateway Changes related to the Gateway actor protocol General core protocol related changes on-chain On-chain business logic labels Oct 11, 2023
@h5law h5law added this to the Shannon TestNet milestone Oct 11, 2023
@h5law h5law requested a review from Olshansk October 11, 2023 16:18
@h5law h5law self-assigned this Oct 11, 2023
@Olshansk
Copy link
Member

@h5law Make sure to update all the PR/Issue metadata
Screenshot 2023-10-11 at 6 49 39 PM

Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h5law Look at the git history on main to review the git message I used for PRs like these.

Also, make sure to update the PR metadata.

@h5law h5law merged commit 8be5d05 into main Oct 12, 2023
3 checks passed
@h5law h5law deleted the scaffold_gateway branch October 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gateway Changes related to the Gateway actor on-chain On-chain business logic protocol General core protocol related changes
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants