-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gateway] Add the Gateway type definition #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h5law
added
gateway
Changes related to the Gateway actor
protocol
General core protocol related changes
on-chain
On-chain business logic
labels
Oct 11, 2023
Olshansk
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need two PRs:
- Scaffold the type (see [1] as an example)
- In a later PR, we add the types (which will require updating a lot of tests)
[1] #48
Olshansk
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h5law Another friendly reminder to please update the PR metadata. I did it in this one again.
bryanchriswhite
added a commit
that referenced
this pull request
Oct 13, 2023
* pokt/main: (25 commits) [Gateway] Scaffold the Gateway type (#57) [Gateway] Scaffold Gateway module and nothing else fix: post-merge imports [Session] Adding the Session type (#54) [WIP][Session] Adding the Relay type (#53) refactor: move `Supplier` protobuf type to `pocket.shared` package (x/shared/types/) Reply to final comments and make things compile WIP - Adding an alternative session implementation Updated comments Regenerate openapi.yml Updated session.proto Added session examples from all the places Ran ignite scaffold type session --module session --yes [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#50) [Supplier] Scaffolded the UnstakeSupplier message and nothing else (#52) [Application] Scaffolded the Application type (without CRUD messages) and nothing else (#47) [Supplier] Scaffolded the Supplier type (without CRUD messages) and nothing else (#48) [Service] Just scaffold the Service module without any params (#37) [Supplier] Scaffolded the StakeSupplier message and nothing else (#51) [Supplier] Scaffolded the StakeSupplier message and nothing else (#49) ...
Olshansk
pushed a commit
that referenced
this pull request
Oct 16, 2023
Simply ran ``` ignite scaffold map gateway --module gateway --signer address --no-message --index address --yes ```
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Simply ran ``` ignite scaffold map gateway --module gateway --signer address --no-message --index address --yes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran
ignite scaffold map gateway --module gateway --signer address --no-message --index address --yes
Summary generated by Reviewpad on 12 Oct 23 12:28 UTC
This pull request includes various changes to multiple files. Here is a summary of the diff:
Changes to the file
x/gateway/gateway_test.go
:GatewayList
field in theGenesisState
struct.GatewayList
in thegenesisState
andgot.GatewayList
.Changes to the file
genesis_test.go
:Changes to the file
query_gateway_test.go
:Changes to the file
query_gateway.go
:keeper
package with two functions:GatewayAll
andGateway
.cosmos-sdk
and thequery
package.Changes to the file
gateway.go
:Gateway
struct.Changes to the file
gateway.proto
:Gateway
with anaddress
field of type string.proto/pocket/gateway
directory and belongs to thepocket.gateway
package.pocket/x/gateway/types
.Changes to the file
genesis.go
:InitGenesis
function to set gateway elements from the provided genesis state.ExportGenesis
function to set thegatewayList
field by callingk.GetAllGateway(ctx)
.Changes to the file
gateway_test.go
:Gateway
struct's operations.Changes to the file
types/key_gateway.go
:Changes to the
openapi.yml
file:Changes to the
x/gateway/types/genesis.go
file:GatewayList
field initialization.Changes to the file
x/gateway/client/cli/query_gateway_test.go
:Changes to the file
x/gateway/types/genesis.go
:Changes to the file
query.go
:These changes aim to enhance various aspects of the gateway module's functionality, including testing, querying, and validation.
Issue
Fixes (in part) 19
Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist