Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supplier] refactor: supplier type to shared protobuf package #58

Merged
merged 10 commits into from
Oct 13, 2023
Merged

[Supplier] refactor: supplier type to shared protobuf package #58

merged 10 commits into from
Oct 13, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 11, 2023 •
edited
Loading

Summary

image

Issue

Related to #54

This resolves the dependency cycle between the pocket.supplier & pocket.session protobuf packages by introducing a new pocket.shared package. pocket.session.Session depends on Supplier, and pocket.supplier.MsgCreateClaim (& MsgSubmitProof) depend on pocket.session.SessionHeader.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify): Refactor

Testing

  • Run all unit tests: make go_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added the supplier Changes related to the Supplier actor label Oct 11, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Oct 11, 2023
@bryanchriswhite bryanchriswhite self-assigned this Oct 11, 2023
@bryanchriswhite bryanchriswhite mentioned this pull request Oct 11, 2023
Merged
10 tasks
@bryanchriswhite bryanchriswhite changed the base branch from main to issues/10/scaffold_session_type October 11, 2023 19:32
@bryanchriswhite bryanchriswhite force-pushed the refactor/shared-supplier-type branch 2 times, most recently from 3b7924e to cc2c553 Compare October 11, 2023 20:25
@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 11, 2023 20:25
Base automatically changed from issues/10/scaffold_session_type to main October 11, 2023 23:10
Olshansk
Olshansk previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@bryanchriswhite bryanchriswhite merged commit 26ffa80 into main Oct 13, 2023
3 checks passed
@bryanchriswhite bryanchriswhite deleted the refactor/shared-supplier-type branch October 13, 2023 06:02
okdas pushed a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite
Merge pull request #58 from pokt-network/refactor/shared-supplier-type
3126ee4 
[Supplier] refactor: supplier type to shared protobuf package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@bryanchriswhite bryanchriswhite

Labels
supplier Changes related to the Supplier actor
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @Olshansk