-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] Add basics of the E2E suite #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h5law
added
the
testing
Test (or test utils) additions, fixes, improvements or other
label
Oct 13, 2023
okdas
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olshansk
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at this after it was merged. LGTM overall but requested a couple of improvements.
bryanchriswhite
added a commit
that referenced
this pull request
Oct 18, 2023
* pokt/main: [Service] Added the `Service` type Updated the command for unit tests in the PR template Updated PR template [Miner] chore: scaffold create-claim message (#43) [E2E] Add basics of the E2E suite (#62) [Gateway] Scaffold the unstake gateway message and nothing else (#67) [Gateway] Scaffold the gateway stake message and nothing else (#66) Add placeholder for auto-generated packages
10 tasks
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports over the basics of the gherkin suite from the old v1 repo. It contains a "help" test and a "send" test to ensure this works with k8s localnet.
Summary generated by Reviewpad on 14 Oct 23 11:55 UTC
This pull request includes several changes across multiple files:
In the file
node.go
, a new file has been added that provides functionalities related to interacting with a node using thepocketd
binary. It includes the declaration of a package namede2e
, import statements for required packages, variable definitions, struct definitions, interface declaration, and function implementations.A new file named
help.feature
has been added in thee2e/tests
directory. It defines a feature for the root namespace and includes a scenario for when a user needs help with thepocketd
binary. The scenario includes steps for checking if the user has the binary installed, running the "help" command, verifying the expected output, and validating the error-free exit of the binary.Changes in the file
init_test.go
involve importing necessary packages and libraries, defining a regular expression, declaring a struct, and implementing multiple test functions related to end-to-end testing and interacting withpocketd
binary.Another new file named
send.feature
has been added in thee2e/tests
directory. It defines a feature called "Tx Namespace" with a scenario named "User can send uPOKT". This scenario tests if the user can successfully send 10000 uPOKT to another address using thepocketd
binary.The
go.mod
file has been modified to add new dependencies and update existing ones.In the
Makefile
diff, modifications include updates to thePOCKET_NODE
variable assignment, addition of a new targettest_e2e
for running end-to-end tests, modification of thego_test
target, and exclusion of theMakefile
itself from a search pattern.These changes add new files, functionalities, and dependencies to the codebase and make improvements to existing files.
Issue
Fixes (in part) 16
Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist