-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] fix: run make go_mockgen
step
#63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
testing
Test (or test utils) additions, fixes, improvements or other
infra
Infra or tooling related improvements, additions or fixes
labels
Oct 13, 2023
bryanchriswhite
force-pushed
the
fix/ci-mockgen
branch
2 times, most recently
from
October 13, 2023 15:09
c34dc06
to
5a771df
Compare
Olshansk
previously approved these changes
Oct 16, 2023
.github/workflows/go.yml
Outdated
@@ -27,8 +27,17 @@ jobs: | |||
with: | |||
go-version: "1.20" | |||
|
|||
- name: Generate protobufs | |||
run: ignite generate proto-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'm surprised that this works without out the
--yes
flag. Does the workflow automatically say yes? - Consider using
make proto_regen
instead
@bryanchriswhite After the minor change above, consider also basing thing against main so we can merge it in. |
10 tasks
Olshansk
approved these changes
Oct 18, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Oct 19, 2023
* main: [Miner, Supplier] chore: scaffold submit-proof message (#44) [Application] Implement MsgUnstakeApplication & Add Extensive Tests (#72) [Gateway] Implement UnstakeGateway message and add Tests (#75) [Gateway] Implement StakeGateway Message and Add Tests (#68) [Application] Implement MsgStakeApplication & Add Extensive Tests (#59) [CI] fix: run `make go_mockgen` step (#63)
bryanchriswhite
added a commit
that referenced
this pull request
Oct 19, 2023
* feat/observable: chore: last minute improvements chore: review improvements chore: improve comment chore: misc. review feedback improvements chore: improve comments refactor: rename `Observable#Close()` to `#UnsubscribeAll()` chore: improve comments chore: improve comments chore: cleanup, simplification, review improvements [Miner, Supplier] chore: scaffold submit-proof message (#44) [Application] Implement MsgUnstakeApplication & Add Extensive Tests (#72) [Gateway] Implement UnstakeGateway message and add Tests (#75) [Gateway] Implement StakeGateway Message and Add Tests (#68) [Application] Implement MsgStakeApplication & Add Extensive Tests (#59) [CI] fix: run `make go_mockgen` step (#63)
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
* fix: run make go_mockgen step * run on all pull requests * don't fail if there is no code to remove * localnet config is not in gitignore yet :) * add go_mockgen --------- Co-authored-by: DK <[email protected]> Co-authored-by: Dima Kniazev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary generated by Reviewpad on 17 Oct 23 23:06 UTC
This pull request includes the following changes:
Patch 1/5:
make go_mockgen
command to the build process.Patch 2/5:
main
branch.Patch 3/5:
Makefile
to avoid failing when there is no code to remove.Patch 4/5:
localnet_config.yaml
file, which was previously not ignored by git.Patch 5/5:
make go_mockgen
command to generate mocks for testing purposes.Please review these changes.
Issue
Fixes CI failure in #59
CI did not have
mockgen
installed and needed to generate protobufs before runningmockgen
.Type of change
Select one or more:
Testing
make test_all_unit
Sanity Checklist