[Gateway] Scaffold the unstake gateway message #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
previously approved these changes
Oct 16, 2023
Olshansk
approved these changes
Oct 16, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Oct 18, 2023
* pokt/main: [Service] Added the `Service` type Updated the command for unit tests in the PR template Updated PR template [Miner] chore: scaffold create-claim message (#43) [E2E] Add basics of the E2E suite (#62) [Gateway] Scaffold the unstake gateway message and nothing else (#67) [Gateway] Scaffold the gateway stake message and nothing else (#66) Add placeholder for auto-generated packages
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
Ran ``` ignite scaffold message unstake-gateway --module gateway --signer address --yes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran
Summary generated by Reviewpad on 16 Oct 23 18:06 UTC
This pull request includes various changes to multiple files:
A new file named
tx_unstake_gateway.gois added in thex/gateway/client/clidirectory. It defines a commandCmdUnstakeGatewayfor unstaking a gateway and includes transaction flags.In the
x/gateway/typespackage, a new file namedmessage_unstake_gateway.gois added. It defines the message typeMsgUnstakeGatewayfor unstaking a gateway, along with necessary methods and helper functions.A new test file for the
MsgUnstakeGatewaytype in thetypespackage is added. It tests theValidateBasicfunction for different scenarios.The file
module_simulation.goincludes changes related to simulating theMsgUnstakeGatewaymessage.The file
gateway/types/codec.goincludes changes in the registration ofMsgUnstakeGatewaymessage type.The file
tx.protoin thepocket/gatewaydirectory includes changes related to adding a new RPC method for unstaking a gateway.The
go.modfile includes changes in the dependencies of the project.A new file named
msg_server_unstake_gateway.goin thex/gateway/keeperpackage includes the initial structure for handling unstaking of a gateway.In the
x/gateway/simulationpackage, a new file namedunstake_gateway.goincludes the initial structure for simulating the unstaking of a gateway.The file
tx.goincludes changes related to the variableDefaultRelativePacketTimeoutTimestampand the addition of theCmdUnstakeGateway()command.The file
docs/static/openapi.ymlincludes changes in the definitions ofMsgUnstakeGatewayResponse,MsgStakeGatewayResponse, andParams.These changes add new functionality and improve the existing codebase. Let me know if you need further assistance!
Issue
Fixes (in part) 19
Type of change
Select one or more:
Testing
make test_all_unitSanity Checklist