[Service] Ran ignite scaffold type service --module service --yes

[Olshansk]

Summary

Created the service type by running the following command:

ignite scaffold type service --module service --yes

Human Summary

• Added and defined the Service type plus supporting structures
• Move the Service type from service to shared

AI Summary

Summary generated by Reviewpad on 17 Oct 23 14:56 UTC

This pull request introduces new protobuf files and modifies existing ones. It seems to resolve circular dependencies and add new definitions related to service configuration and identifiers. There are also some comments suggesting further research and future improvements.

Issue

• [Service] Foundation for the Service module #10

Type of change

Select one or more:

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Documentation
• Other (specify)

Testing

• Run all unit tests: make test_all_unit
• Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

• I have tested my changes using the available tooling
• I have performed a self-review of my own code
• I have commented my code, updated documentation and left TODOs throughout the codebase

[red-0ne]

Looks good to me!

Just a note regarding RPCType. In that setup we have no way to prevent a Supplier to declare an RPCType on its SupplierServiceConfig that does not exist for a given Service.
But this could also be the desired behavior if we assume that a Service should not enforce this (eg. Ethereum does not have an "official" GRPC RPCType but a Supplier could provide an implementation that does 🧠 )

[Olshansk]

@red-0ne That is indeed the desired behaviour!