Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Foundation for load testing telemetry #832
[Observability] Foundation for load testing telemetry #832
Changes from 34 commits
ff762ea
1aad6ca
ee84b91
025698a
b7c5bd3
549710e
208f824
90624df
8fa8e04
8bf2212
0262062
d39fb8f
69f3df5
fbfe6d1
cfa7dc7
050687a
4786097
83f1b7d
10eb2be
d28f514
cdf62fc
6628c07
7ab27ac
72b3086
aa61ace
eb96ae6
2cd91de
d966241
ce77cc7
e5cc4f6
4a0b12b
497e0e3
814d0a2
cd438dc
54d6c0f
dd5276d
fc53e96
a247a8e
5f693e5
6cac26c
a13c2ec
6cd43f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked in Cosmos & Comet and the names for these are usually
RPCConfig
,CustomAppConfig
,serverconfig.Config
, etc...Wdyt of
PoktrollAppConfig
?Additional
feels weird...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CN(aming)O at work