-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] upgrade/chain halt recovery #837
base: main
Are you sure you want to change the base?
Conversation
Items to add:
|
@okdas Let's add the details here as well: https://x.com/olshansky/status/1846211059989778741 |
@Olshansk can I get a review on this PR, please? I think I want to investigate/add information about the new Cosmovisor feature mentioned in |
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 837) |
It is ready now! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great docs @okdas! 🙌 😍
docusaurus/docs/develop/developer_guide/chain_halt_troubleshooting.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/develop/developer_guide/recovery_from_chain_halt.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/develop/developer_guide/recovery_from_chain_halt.md
Outdated
Show resolved
Hide resolved
|
||
## Submitting the upgrade on-chain | ||
|
||
The `MsgSoftwareUpgrade` can be submitted using the following command: | ||
|
||
```bash | ||
poktrolld tx authz exec PATH_TO_TRANSACTION_JSON --from pnf | ||
poktrolld tx authz exec $PATH_TO_UPGRADE_TRANSACTION_JSON --from=pnf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command needs to be adjusted for different networks, I'd prefer the PNF/TestNet Devs to write the full CLI command.
|
||
5. **(`old` repo)** - Clean up and generate an empty genesis using the old version. | ||
```bash | ||
rm -rf ~/.poktroll && ./release_binaries/poktroll_darwin_arm64 comet unsafe-reset-all && make localnet_regenesis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these commands, I want a developer to 100% understand what they are doing, checking all arguments.
|
||
8. **(`old` repo)** Submit the upgrade transaction. **Note:** The upgrade height in the transaction should be higher than the current block height. Adjust and submit if necessary: | ||
```bash | ||
./release_binaries/poktroll_darwin_arm64 tx authz exec tools/scripts/upgrades/local_test_v0.2.json --from=pnf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make target?
Note: we can use env vars to pass arguments (see: poktroll_addr
, acc_balance_query
, query_tx
, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these commands, I want a developer to 100% understand what they are doing, checking all arguments.
…lt.md Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Bryan White <[email protected]>
…lt.md Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Bryan White <[email protected]>
…ll into dk-upgrade-learnings
@Olshansk I noticed you started reviewing this. I addressed @bryanchriswhite review and pushed more changes to the branch. Just FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a bunch of changes. A couple lingering comments but g2g afterwards!
|
||
.PHONY: localnet_show_upgrade_plan | ||
localnet_show_upgrade_plan: ## Shows the upgrade plan on local node | ||
poktrolld query upgrade plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto regarding --home=$(POKTROLLD_HOME) --node $(POCKET_NODE)
here too?
|
||
.PHONY: localnet_cancel_upgrade | ||
localnet_cancel_upgrade: ## Cancels the planed upgrade on local node | ||
poktrolld tx authz exec tools/scripts/upgrades/authz_cancel_upgrade_tx.json --gas=auto --from=pnf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't we need to
--home=$(POKTROLLD_HOME) q bank balances $(ACC) --node $(POCKET_NODE)
- Don't we need to add fees?
Summary
Performed the first upgrade on the Alpha TestNet. Add some documentation changes to prevent some issues in the future.
Issue
N/A
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist