[Upgrade] Alpha TestNet v0.0.10 upgrade #894

okdas · 2024-10-25T18:35:51Z

Summary

Prep for v0.0.10 release and upgrade.

Type of change

Select one or more from the following:

New feature, functionality or library
Consensus breaking; add the consensus-breaking label if so. See [Infra] Automatically add the consensus-breaking label #791 for details
Bug fix
Code health or cleanup
Documentation
Other (specify)

Testing

Went through upgrade testing locally.

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

…ade-0.0.10

okdas · 2024-10-28T23:17:33Z

Merged in 78a7445, seems like there are no changes that would affect the release so gtg.

…ade-0.0.10

okdas · 2024-10-31T01:29:44Z

Merged in ff76430 and began testing the upgrade locally.

The upgrade failed initially. Here's a gist with a panic: https://gist.github.com/okdas/535bc3c0282483fef27454c70d889aa6

I believe the reason is we've changed the data type of the protobuf field here. Meaning the new version is unable to map the existing uint64 in kvstore into a Coin that it now expects.

After I manually created a new prooftypes.Params the upgrade went through.

We probably need to treat protobuf files as they used are production - meaning no type/field changes, any change that needs to be done should go through adding a new field, ensuring backwards-compatibility.

gitguardian · 2024-11-06T19:14:36Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

Olshansk · 2024-11-06T19:15:21Z

We probably need to treat protobuf files as they used are production - meaning no type/field changes, any change that needs to be done should go through adding a new field, ensuring backwards-compatibility.

Noted. We'll start doing this in Beta. We'll have one last cleanup opportunity prior to mainnet.

cc @red-0ne

okdas · 2024-11-13T23:31:27Z

I'm going to create a release using f0d0e7a as this is the commit that has been tested using this branch.

Looking at new changes in main branch, there are more state changes required in the upgrade. As discussed in the meeting yesterday, we will add them in another upgrade shortly after.

Let's practice upgrades!

okdas · 2024-11-13T23:58:26Z

The release has been created: https://github.com/pokt-network/poktroll/releases/tag/v0.0.10

I did not use main branch specifically as there are more commits now that would require a bit more testing. We'll issue the next upgrade with the new changes. Probably next week.

@Olshansk let's get this in main to preserve the upgrade code! :)

app/upgrades/types.go

Olshansk · 2024-11-14T22:08:06Z

tools/scripts/upgrades/local_test_v0.0.10.json

+                "plan": {
+                    "name": "v0.0.10",
+                    "height": "20",
+                    "info": "NOT NEEDED FOR LOCAL TESTING"


#PUC why we have this file then

app/upgrades/v0.0.10.go

okdas · 2024-11-14T23:24:23Z

Thanks for the review @Olshansk.

At this point, with many changes here, I want to delete the v0.0.10 version we currently have a release for, remove the merges from the main branch (so the code only contains the commits we wrote an upgrade for), and test the upgrade again.

Will re-create release and apply an upgrade on the network after that.

okdas · 2024-11-15T01:09:18Z

I've verified all new params and grants locally - we're good to upgrade!
I'll create a new release and issue an upgrade on alpha network now.

github-actions · 2024-11-15T01:43:56Z

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

okdas · 2024-11-15T18:28:35Z

@Olshansk the upgrade has been applied on Alpha TestNet. We don't really have to merge this, but I still would to have an example for future upgrades.

app/upgrades/types.go

Olshansk · 2024-11-15T21:24:15Z

app/upgrades/types.go

+// Should we use the same address/wallet for DAO or find a way to detect the network the upgrade is being applied to,
+// to pick different addresses depending on the name of the network? (e.g chain-id)
+
+const (


Ty for the comments

Co-authored-by: Daniel Olshansky <[email protected]>

* todo_beta/upnext: [C&P] Populate NumEstimatedComputeUnits and ClaimedUpokt of Claim and Proof events (#927) [Tokenomics] feat: add `dao_reward_address` param to tokenomics module (#922) chore: review feedback improvements chore: review feedback improvements [Service] Return the default RelayMinerDifficuly for services that have none. (#926) [Upgrade] Alpha TestNet v0.0.10 upgrade (#894) Update reviewdog.yml

prep for v0.0.10 upgrade

43fee3d

okdas added the code health Cleans up some code label Oct 25, 2024

okdas added this to the Shannon Beta TestNet Launch milestone Oct 25, 2024

okdas self-assigned this Oct 25, 2024

okdas added 3 commits October 25, 2024 13:34

Add authz authorizations

dd45641

add a potential todo

c3bd48c

Merge remote-tracking branch 'origin/main' into dk-alpha-testnet-upgr…

b17a6a4

…ade-0.0.10

okdas added 4 commits October 30, 2024 17:22

Merge remote-tracking branch 'origin/main' into dk-alpha-testnet-upgr…

c7f1d45

…ade-0.0.10

change upgrade

0d87723

add link to gist with a panic

b83cede

fix the upgrade!

f0d0e7a

okdas marked this pull request as ready for review November 13, 2024 23:54

okdas requested a review from Olshansk November 13, 2024 23:55

Olshansk requested changes Nov 14, 2024

View reviewed changes

requested changes

10d45b7

okdas force-pushed the dk-alpha-testnet-upgrade-0.0.10 branch from 05aeeb2 to 10d45b7 Compare November 15, 2024 00:10

okdas added the push-image CI related - pushes images to ghcr.io label Nov 15, 2024

Empty commit

7b457ca

okdas requested a review from Olshansk November 15, 2024 18:26

Olshansk approved these changes Nov 15, 2024

View reviewed changes

Update app/upgrades/types.go

90e3f32

Co-authored-by: Daniel Olshansky <[email protected]>

okdas merged commit e0aa1ff into main Nov 15, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Upgrade] Alpha TestNet v0.0.10 upgrade #894

[Upgrade] Alpha TestNet v0.0.10 upgrade #894

okdas commented Oct 25, 2024 •

edited

Loading

okdas commented Oct 28, 2024

okdas commented Oct 31, 2024

gitguardian bot commented Nov 6, 2024 •

edited

Loading

Olshansk commented Nov 6, 2024

okdas commented Nov 13, 2024

okdas commented Nov 13, 2024

Olshansk Nov 14, 2024

okdas commented Nov 14, 2024

okdas commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

okdas commented Nov 15, 2024

Olshansk Nov 15, 2024

[Upgrade] Alpha TestNet v0.0.10 upgrade #894

[Upgrade] Alpha TestNet v0.0.10 upgrade #894

Conversation

okdas commented Oct 25, 2024 • edited Loading

Summary

Type of change

Testing

Sanity Checklist

okdas commented Oct 28, 2024

okdas commented Oct 31, 2024

gitguardian bot commented Nov 6, 2024 • edited Loading

️✅ There are no secrets present in this pull request anymore.

Olshansk commented Nov 6, 2024

okdas commented Nov 13, 2024

okdas commented Nov 13, 2024

Olshansk Nov 14, 2024

Choose a reason for hiding this comment

okdas commented Nov 14, 2024

okdas commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

okdas commented Nov 15, 2024

Olshansk Nov 15, 2024

Choose a reason for hiding this comment

okdas commented Oct 25, 2024 •

edited

Loading

gitguardian bot commented Nov 6, 2024 •

edited

Loading