Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LocalNet] change moniker from validator1 to sequencer1 #9

Merged
merged 4 commits into from
Oct 6, 2023
Merged

[LocalNet] change moniker from validator1 to sequencer1 #9

merged 4 commits into from
Oct 6, 2023

Conversation

okdas
Copy link
Member

@okdas okdas commented Oct 5, 2023 •
edited
Loading

Summary

LocalNet: changes moniker and removes private keys and genesis from git.

Changing the moniker required regenerating the genesis, so I decided to also fix the issue with us modifying genesis in the same PR.

reviewpad:summary

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all_unit
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@okdas okdas closed this Oct 6, 2023
@okdas okdas deleted the dk-change-moniker branch October 6, 2023 00:59
@okdas okdas restored the dk-change-moniker branch October 6, 2023 00:59
@okdas okdas reopened this Oct 6, 2023
@okdas okdas changed the title change moniker from validator1 to sequencer1 [LocalNet] change moniker from validator1 to sequencer1 Oct 6, 2023
@okdas okdas self-assigned this Oct 6, 2023
@okdas okdas added the infra Infra or tooling related improvements, additions or fixes label Oct 6, 2023
@okdas okdas added this to the Shannon TestNet milestone Oct 6, 2023
@okdas okdas requested a review from Olshansk October 6, 2023 01:05
okdas
okdas commented Oct 6, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@okdas okdas merged commit 4767c46 into main Oct 6, 2023
4 checks passed
@okdas okdas deleted the dk-change-moniker branch October 6, 2023 19:42
okdas added a commit that referenced this pull request Nov 14, 2024
@okdas
[LocalNet] change moniker from validator1 to sequencer1 (#9)
b8c3a94 
* change moniker

* also rename the keyring file

* --wip-- [skip ci]

* also address constantly changing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@okdas okdas

Labels
infra Infra or tooling related improvements, additions or fixes
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
2 participants
@okdas @Olshansk