-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Health] Harden settlement (part 2: (non-)halting settlement error alignment) #904
base: issues/881/refactor/settlement
Are you sure you want to change the base?
[Code Health] Harden settlement (part 2: (non-)halting settlement error alignment) #904
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
// TODO_TEST(@bryanchriswhite): Settlement proceeds in the face of errors | ||
// - Does not block settling of other claims in the same session | ||
// - Does not block setting subsequent sessions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO_TEST(@bryanchriswhite): Settlement proceeds in the face of errors | |
// - Does not block settling of other claims in the same session | |
// - Does not block setting subsequent sessions |
d9d88c1
to
1e1c535
Compare
Summary
Adds integration tests which categorize and exercise claim/proof settlement errors into "SHOULD halt" and "SHOULD NOT halt".
Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist