Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] Harden settlement (part 2: (non-)halting settlement error alignment) #904

Draft
wants to merge 2 commits into
base: issues/881/refactor/settlement
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Adds integration tests which categorize and exercise claim/proof settlement errors into "SHOULD halt" and "SHOULD NOT halt".

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Nov 6, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 6, 2024
Copy link

gitguardian bot commented Nov 6, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bryanchriswhite bryanchriswhite changed the base branch from main to issues/881/refactor/settlement November 6, 2024 16:21
@bryanchriswhite bryanchriswhite added the tokenomics Token Economics - what else do you need? label Nov 12, 2024
Comment on lines 29 to 30
// TODO_TEST(@bryanchriswhite): Settlement proceeds in the face of errors
// - Does not block settling of other claims in the same session
// - Does not block setting subsequent sessions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO_TEST(@bryanchriswhite): Settlement proceeds in the face of errors
// - Does not block settling of other claims in the same session
// - Does not block setting subsequent sessions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. on-chain On-chain business logic tokenomics Token Economics - what else do you need?
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants