[Session Params] Add MsgUpdateParam to session module
#906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
governance
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ner authority name as_type --response params
bryanchriswhite
force-pushed
the
todo_beta/params/session/MsgUpdateParam
branch
from
6b43ee5 to
479c0ae
Compare
bryanchriswhite
force-pushed
the
todo_beta/params/session/MsgUpdateParam
branch
from
479c0ae to
9eba3b1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
red-0ne
approved these changes
Nov 12, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Nov 12, 2024
…pplier_per_session * pokt/main: [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files
bryanchriswhite
added a commit
that referenced
this pull request
Nov 12, 2024
…beta/params/mint_allocation_supplier * todo_beta/refactor/mint_allocation_proposer: [Session Params] Add `num_suppliers_per_session` param to session module (#907) refactor: consolidate float params to float64 chore: review feedback improvements [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files # Conflicts: # x/tokenomics/keeper/msg_server_update_param.go # x/tokenomics/types/message_update_param.go
bryanchriswhite
added a commit
that referenced
this pull request
Nov 12, 2024
…ta/refactor/mint_allocation_supplier * todo_beta/params/mint_allocation_supplier: chore: review feedback improvements chore: review feedback improvements fixup! HEAD [Session Params] Add `num_suppliers_per_session` param to session module (#907) refactor: consolidate float params to float64 chore: review feedback improvements [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files
bryanchriswhite
added a commit
that referenced
this pull request
Nov 12, 2024
…beta/params/mint_allocation_source_owner * todo_beta/refactor/mint_allocation_supplier: chore: review feedback improvements chore: review feedback improvements fixup! HEAD [Session Params] Add `num_suppliers_per_session` param to session module (#907) refactor: consolidate float params to float64 chore: review feedback improvements [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files # Conflicts: # x/tokenomics/keeper/msg_server_update_param.go # x/tokenomics/types/message_update_param.go
bryanchriswhite
added a commit
that referenced
this pull request
Nov 12, 2024
…odo_beta/params/mint_allocation_application * todo_beta/refactor/mint_allocation_source_owner: fixup! HEAD chore: review feedback improvements fix: e2e tests chore: review feedback improvements chore: review feedback improvements fixup! HEAD [Session Params] Add `num_suppliers_per_session` param to session module (#907) refactor: consolidate float params to float64 chore: review feedback improvements [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files # Conflicts: # x/tokenomics/keeper/msg_server_update_param.go # x/tokenomics/types/message_update_param.go
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary Add `MsgUpdateParam` and handler to the session module to support individual parameter updates. **@Reviewer, use the updated docs in #839 to validate these changes.** ## Issue - `TODO_BETA` ## Type of change Select one or more from athe following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable
bryanchriswhite
added a commit
that referenced
this pull request
Nov 14, 2024
…pdates * pokt/main: (51 commits) [RelayMiner] Supplier rate limiting (#895) [Tokenomics] refactor: `MintAllocationApplication` var usage to param usage (#918) [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917) [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916) [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915) [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914) [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913) [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912) [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911) [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910) [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909) [quick-pr] change full-node.sh script links (#920) [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908) [Session Params] Add `num_suppliers_per_session` param to session module (#907) [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files [TODOs] Update #2 to `TODO_BETA` to only reflect ACTUAL blockers (#900) [Workflow] Enforce `TODO_UPNEXT` comments to have an associated username (#896) [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) ...
bryanchriswhite
added a commit
that referenced
this pull request
Nov 14, 2024
…tlement * pokt/main: [RelayMiner] Supplier rate limiting (#895) [Tokenomics] refactor: `MintAllocationApplication` var usage to param usage (#918) [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917) [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916) [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915) [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914) [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913) [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912) [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911) [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910) [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909) [quick-pr] change full-node.sh script links (#920) [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908) [Session Params] Add `num_suppliers_per_session` param to session module (#907) [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files [TODOs] Update #2 to `TODO_BETA` to only reflect ACTUAL blockers (#900) [Workflow] Enforce `TODO_UPNEXT` comments to have an associated username (#896)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
MsgUpdateParamand handler to the session module to support individual parameter updates.@Reviewer, use the updated docs in #839 to validate these changes.
Issue
TODO_BETAType of change
Select one or more from athe following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist