-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Add protocheck status-errors
subcmd to check for non-gRPC status error returns
#929
Draft
bryanchriswhite
wants to merge
18
commits into
main
Choose a base branch
from
issues/860/chore/grpc-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e899d52
wip: add protocheck status-err subcommand
bryanchriswhite 62c0eae
wip: ...
bryanchriswhite a25688b
wip: PoC working
bryanchriswhite c31b3ef
wip: cleanup
bryanchriswhite e24e241
wip: cleanup
bryanchriswhite 6378150
wip: todo
bryanchriswhite 1e823d6
wip:...
bryanchriswhite a9c2e2e
wip: chore: support custom polyzero writer
bryanchriswhite 16ba812
wip: ...
bryanchriswhite c5c659f
chore: add check_grpc_status_errors make target
bryanchriswhite 68d76e0
wip: more better
bryanchriswhite cc2af0c
wip: error assignment case wrangled 🙌
bryanchriswhite 669765b
chore: comment cleanup
bryanchriswhite 4169627
wip: refactoring and cleaning up
bryanchriswhite 38eaa57
chore: rename protocheck cmd files
bryanchriswhite 5d32441
squash! HEAD - refactor: extract flags & encapsulate logger
bryanchriswhite b9f9a2c
refactor: find and replace "exonerate" with "exclude"
bryanchriswhite 392aa7e
fixup: flags
bryanchriswhite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_COMMIT: godoc & test...