Update the Makefile to use localhost in the default pocket node URL #992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Makefile to use
localhost
in the default pocket node URL.Issue
Using the loopback address
127.0.0.1
instead oflocalhost
results in an error when sending TXs on some LocalNet setups:e.g.:
Results in the following error:
rpc error: code = InvalidArgument desc = invalid Bech32 prefix; expected cosmos, got pokt: invalid request
This also breaks E2E tests as
acc_initialize_pubkeys
Makefile target used in the E2E tests runs commands similar to the above to fund the accounts.Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist