Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clients] embed ParamsQuerier into ServiceQueryClient #998

Draft
wants to merge 7 commits into
base: issues/543/params-querier/proof
Choose a base branch
from
Draft

[Clients] embed ParamsQuerier into ServiceQueryClient #998

wants to merge 7 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Embed the ParamsQuerier interface into ServiceQueryClient and update the implementations.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added service Anything related to general-purpose RPC service support off-chain Off-chain business logic labels Dec 11, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 11, 2024
@bryanchriswhite bryanchriswhite changed the title refactor: service query client [Clients] embed ParamsQuerier into ServiceQueryClient Dec 11, 2024
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from 603602e to d074fac Compare December 11, 2024 16:41
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/service branch from 82f3ad7 to e804abd Compare December 11, 2024 16:58
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch from d074fac to bb9a3ab Compare December 11, 2024 17:10
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/service branch from e804abd to cd5f64c Compare December 11, 2024 17:10
@bryanchriswhite bryanchriswhite linked an issue Dec 11, 2024 that may be closed by this pull request
[Off-Chain] ModuleParamsClient & Historical Params #543
Open
4 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/543/params-querier/proof branch 2 times, most recently from 06c7c0b to c0f615c Compare December 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bryanchriswhite bryanchriswhite

Labels
off-chain Off-chain business logic service Anything related to general-purpose RPC service support
Projects
Shannon
Status: 🏗 In progress
Milestone
Shannon Beta TestNet Support
Development

Successfully merging this pull request may close these issues.

[Off-Chain] ModuleParamsClient & Historical Params
1 participant
@bryanchriswhite