-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Add clarifying comment to ClosestProof
documentation
#32
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 8 8
Lines 1406 1406
=======================================
Hits 1171 1171
Misses 178 178
Partials 57 57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for continuing to push on such a small thing but I think we're deriving more value by thinking it through.
cdde3cb
to
35fbc54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@h5law This is a good addition and on a technical level contains all the details. However, it's a lot of text & content to parse. For someone with context or who is Even I feel like I need to read this multiple times and need to make notes along the way, If you have time, I recommend approaching it like so.
|
Summary
Quick PR to add context to the closest proof method
Issue
Fixes N/A
Type of change
Please mark the relevant option(s):
Testing
make test_all
make benchmark_{all | suite name}
Required Checklist
godoc
format comments see: tip.golang.org/doc/comment)If Applicable Checklist