-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Cleanup Docs and Workflows #34
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 8 8
Lines 1406 1406
=======================================
Hits 1171 1171
Misses 178 178
Partials 57 57 ☔ View full report in Codecov by Sentry. |
3e652fb
to
28ff984
Compare
ae6db39
to
2d215eb
Compare
@@ -0,0 +1,9 @@ | |||
# Only post coverage comments and not pass/fail reports in the CI checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need this at all given that we're not really acting on the feedback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the coverage percentages, shows the lib has good test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use the feedback when I add new features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the coverage percentages, shows the lib has good test coverage
👍
I use the feedback when I add new features
When you put together a contribution guide for this repo, make sure this is clear.
As a n00b, I'd probably think this tool I've never seen or used is giving me a ⚠️. Do I ignore it or keep going?
Summary
Human Summary
This PR moves all documentation to the
docs/
subdir and updates the workflow files. It also makes codecov informational only instead of passing/failing CI checks.AI Summary
Summary generated by Reviewpad on 03 Jan 24 14:06 UTC
This pull request includes the following changes:
Ignoring specific files and directories: The ".DS_Store" file, which are Mac OS X system files, and the ".idea/" directory, which contains Goland and JetBrains IDE files, are now being ignored. Additionally, a new file called ".tool-versions" is also being ignored, which is a local tool-versions file for asdf.
Changes to the
.github/codecov.yml
file: This file has been added with a mode of 100644. Thecoverage
section has been added with thestatus
configuration. Theinformational
property has been set totrue
for both theproject
andpatch
sections.Renaming and content changes for the
SMT.md
file: The file has been renamed tosmt.md
and includes an added section on "Closest Proof Use Cases." The "Compression" and "Data Loss" sections have been updated. An additional change is the renaming of documentation links for "KVStore" and "MerkleSumTrie" to lowercase.Changes to the
docs/KVStore.md
file: This file has undergone a 90% similarity index change and has been renamed tokvstore.md
. The changes involve reformatting the indentation of subheadings under the "Implementation" and "Accessor Methods" sections.Changes to the
MerkleSumTrie.md
file: The filename has been changed tomerkle-sum-trie.md
. There have been changes in the headings and subheadings, including indentation adjustments. A file link for theSMT documentation
has also been updated.Updates to the
test.yml
file: The workflow name has been changed, the value of an environment variable has been updated, and various modifications have been made to different steps.Please review these changes and ensure that they align with the intended modifications.
Issue
N/A
Type of change
Please mark the relevant option(s):
Testing
make test_all
make benchmark_{all | suite name}
Required Checklist
godoc
format comments see: tip.golang.org/doc/comment)If Applicable Checklist