Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Cleanup Docs and Workflows #34

Merged
merged 5 commits into from
Jan 3, 2024
Merged

[Documentation] Cleanup Docs and Workflows #34

merged 5 commits into from
Jan 3, 2024

Conversation

h5law
Copy link
Collaborator

@h5law h5law commented Dec 23, 2023

Summary

Human Summary

This PR moves all documentation to the docs/ subdir and updates the workflow files. It also makes codecov informational only instead of passing/failing CI checks.

AI Summary

Summary generated by Reviewpad on 03 Jan 24 14:06 UTC

This pull request includes the following changes:

  1. Ignoring specific files and directories: The ".DS_Store" file, which are Mac OS X system files, and the ".idea/" directory, which contains Goland and JetBrains IDE files, are now being ignored. Additionally, a new file called ".tool-versions" is also being ignored, which is a local tool-versions file for asdf.

  2. Changes to the .github/codecov.yml file: This file has been added with a mode of 100644. The coverage section has been added with the status configuration. The informational property has been set to true for both the project and patch sections.

  3. Renaming and content changes for the SMT.md file: The file has been renamed to smt.md and includes an added section on "Closest Proof Use Cases." The "Compression" and "Data Loss" sections have been updated. An additional change is the renaming of documentation links for "KVStore" and "MerkleSumTrie" to lowercase.

  4. Changes to the docs/KVStore.md file: This file has undergone a 90% similarity index change and has been renamed to kvstore.md. The changes involve reformatting the indentation of subheadings under the "Implementation" and "Accessor Methods" sections.

  5. Changes to the MerkleSumTrie.md file: The filename has been changed to merkle-sum-trie.md. There have been changes in the headings and subheadings, including indentation adjustments. A file link for the SMT documentation has also been updated.

  6. Updates to the test.yml file: The workflow name has been changed, the value of an environment variable has been updated, and various modifications have been made to different steps.

Please review these changes and ensure that they align with the intended modifications.

Issue

N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all
  • Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

If Applicable Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
  • Add or update any relevant or supporting mermaid diagrams

@h5law h5law added documentation Improvements or additions to documentation enhancement New feature or request code health Related to code cleanup and health of the repo labels Dec 23, 2023
@h5law h5law requested a review from Olshansk December 23, 2023 14:03
@h5law h5law self-assigned this Dec 23, 2023
@reviewpad reviewpad bot added large Pull request is large waiting-for-review This PR is currently waiting to be reviewed and removed documentation Improvements or additions to documentation labels Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db06038) 83.28% compared to head (179f616) 83.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files           8        8           
  Lines        1406     1406           
=======================================
  Hits         1171     1171           
  Misses        178      178           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h5law h5law force-pushed the feat/doc-changes branch from ae6db39 to 2d215eb Compare January 1, 2024 21:18
@@ -0,0 +1,9 @@
# Only post coverage comments and not pass/fail reports in the CI checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need this at all given that we're not really acting on the feedback?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the coverage percentages, shows the lib has good test coverage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the feedback when I add new features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the coverage percentages, shows the lib has good test coverage

👍

I use the feedback when I add new features

When you put together a contribution guide for this repo, make sure this is clear.

As a n00b, I'd probably think this tool I've never seen or used is giving me a ⚠️. Do I ignore it or keep going?

docs/smt.md Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
docs/smt.md Outdated Show resolved Hide resolved
@h5law h5law requested a review from Olshansk January 3, 2024 14:08
@h5law h5law merged commit 883d100 into main Jan 3, 2024
5 checks passed
@h5law h5law deleted the feat/doc-changes branch January 3, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Related to code cleanup and health of the repo enhancement New feature or request large Pull request is large waiting-for-review This PR is currently waiting to be reviewed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants