Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add features related to the usage of the ClosestProof method #43

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

h5law
Copy link
Collaborator

@h5law h5law commented Mar 20, 2024

Summary

Human Summary

  • Adds GetValueHash to SparseMerkleClosestProof type
  • Adds to the TrieSpec (from sm(s)t.Spec()):
    • PathHasherSize()
    • ValueHasherSize()
    • TrieHasherSize()
    • All measured in bytes
  • Enforces that the path passed into ClosestProof and the Proof field of the SparseMerkle(Compact)ClosestProof types is the same length as the spec's PathHasherSize()

AI Summary

reviewpad:summary

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all
  • Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

If Applicable Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
  • Add or update any relevant or supporting mermaid diagrams

@h5law h5law added the enhancement New feature or request label Mar 20, 2024
@h5law h5law requested review from red-0ne and Olshansk March 20, 2024 18:56
@h5law h5law self-assigned this Mar 20, 2024
@h5law h5law merged commit e3dbbbd into main Mar 21, 2024
2 checks passed
@h5law h5law deleted the feat/proof-methods branch March 21, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants