[Code Health] refactor: SMST#Root(), #Sum(), & #Count()

[bryanchriswhite]

Summary

• Add:
  • MerkleSumRoot
  • SMST#MustCount()
  • SMST#MustSum()
  • MerkleSumRoot#MustCount()
  • MerkleSumRoot#DigestSize()
  • MerkleSumRoot#HasDigestSize()
• Refactor:
  • SMST#Root() to return MerkleSumRoot

Human Summary

AI Summary

reviewpad:summary

Issue

Fixes pokt-network/poktroll#584

Type of change

Please mark the relevant option(s):

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Documentation
• Other (specify)

Testing

• Run all unit tests: make test_all
• Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

• I have tested my changes using the available tooling
• I have performed a self-review of my own code
• I have commented my code (godoc format comments see: tip.golang.org/doc/comment)

If Applicable Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
• Add or update any relevant or supporting mermaid diagrams

[red-0ne]

Small NIT comment.

Also smst_test.go seems to use require.Equal(t, uint64(1), impl.Count()) where it should use impl.MustCount().

[Olshansk]

NIT: Move this comment INSIDE the function and keep the godoc more general OR call out a power of two as an explicit example.

[bryanchriswhite]

I'm either not quite following or am just unable to think of an alternative godoc comment that satisfies your suggestion. Do you have a concrete example in mind (i.e., validateBasic returns an error if ...)?