Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows #232

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Fix workflows #232

merged 7 commits into from
Mar 21, 2024

Conversation

guidoderooij
Copy link
Contributor

@guidoderooij guidoderooij commented Mar 21, 2024

From a recent run of the workflows it was noticed that there were some issues reported:

  • The workflows were executed on old Node versions. Solution is to only use Node version 18 and 20
  • Old versions of actions were used. Solution is to use the latest versions

After installing VSCode Github Actions extension it appeared that the logic to cache node_modules was incorrect so that is now also fixed (and verified)

Use Node 18 and 20 and use latest versions of actions
Only works on main branch so not so interesting
Update the used actions to the latest version and use Node 18
@guidoderooij guidoderooij marked this pull request as ready for review March 21, 2024 10:21
@guidoderooij guidoderooij self-assigned this Mar 21, 2024
.github/workflows/release.yml Outdated Show resolved Hide resolved
@emielb emielb merged commit 67215e0 into main Mar 21, 2024
3 checks passed
@emielb emielb deleted the fix-workflows branch March 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants