Add support for async initialisation (similar to option type) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavadeli
changed the title
njirem
suggested changes
Jun 26, 2018
| @@ -90,4 +90,148 @@ describe('rxjs/rxjs', () => { | |||
| expect(complete).to.be.false; | |||
| }); | |||
| }); | |||
|
|
|||
| describe('fromObservable', () => { | |||
| it('should be unresolved when not connected and no fallback is given', () => { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| expect(d$.resolved).to.be.false; | ||
| }); | ||
|
|
||
| it('should subscribe on observable when used to power a reactor', () => { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/derivable/apply-mixins.ts
Outdated
| declare module './base-derivable' { | ||
| export interface BaseDerivable<V> { | ||
| get(): V; | ||
| getOr<T>(t: T): V; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| abstract derive: Derivable<V>['derive']; | ||
| abstract pluck: Derivable<V>['pluck']; | ||
| connected = false; | ||
| _connected$?: SettableDerivable<boolean> = undefined; |
There was a problem hiding this comment.
In following 'documentation' PR, we need to explain this and its relation to the connected$ getter.
| if (state !== unresolved) { | ||
| return state; | ||
| } | ||
| if (derivationStackDepth > 0) { |
njirem
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58, but built into the main Sherlock library. It turned out that a separate sherlock-async library has more downsides than upsides. The implementation is much simpler this way while having very limited overhead.
Note, this is effectively a rewrite of the derivables (reactors and dependency tracking are mostly untouched).
Docs are tracked in separate issues #86 and #87.