Fellowship Treasury #109
Fellowship Treasury #109
Conversation
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Show resolved
Hide resolved
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Show resolved
Hide resolved
| pub const MaxBalance: Balance = Balance::max_value(); | ||
| // The asset's interior location for the paying account. This is the Fellowship Treasury | ||
| // pallet instance (which sits at index 65). | ||
| pub FellowshipTreasuryInteriorLocation: InteriorMultiLocation = PalletInstance(65).into(); |
There was a problem hiding this comment.
I won't block on this but it will be great if there is a way to not having hardcoded number here
There was a problem hiding this comment.
Without pulling in the entire runtime enum, it will have to be declared somewhere, right? Of course if more parachains need this value then it could be pulled up to some common area that they import from.
There was a problem hiding this comment.
maybe we could have a test somewhere to assert the value matches
There was a problem hiding this comment.
This location is not actually the problem, can just read it directly (which I have changed it to do). The problem is more here. I had added two tests and a link to an issue to pull these important pallet indices into a common area.
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Show resolved
Hide resolved
| type OnSlash = (); | ||
| type ProposalBond = HundredPercent; | ||
| type ProposalBondMinimum = MaxBalance; | ||
| type ProposalBondMaximum = MaxBalance; |
There was a problem hiding this comment.
again, out of scope of this PR, but this means the treasury pallet needs some serious refactoring
There was a problem hiding this comment.
related calls were deprecated half year ago, with a note that they will be removed in Feb
| type RuntimeEvent = RuntimeEvent; | ||
| type CreateOrigin = EitherOfDiverse< | ||
| EnsureRoot<AccountId>, | ||
| EitherOfDiverse<EnsureXcm<IsVoiceOfBody<GovernanceLocation, TreasurerBodyId>>, Fellows>, |
There was a problem hiding this comment.
just to confirm, we are happy with this origin configuration?
There was a problem hiding this comment.
Seems reasonable to me.
| @@ -621,6 +639,7 @@ construct_runtime!( | |||
| Proxy: pallet_proxy::{Pallet, Call, Storage, Event<T>} = 42, | |||
| Preimage: pallet_preimage::{Pallet, Call, Storage, Event<T>, HoldReason} = 43, | |||
| Scheduler: pallet_scheduler::{Pallet, Call, Storage, Event<T>} = 44, | |||
| AssetRate: pallet_asset_rate::{Pallet, Call, Storage, Event<T>} = 45, | |||
There was a problem hiding this comment.
nit: I will prefer to use the default syntax to not explicitly listing things here but it maybe good to keep consistent in this PR and do the change later in one go
There was a problem hiding this comment.
Yeah. We really need to switch this.
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
| // pallet | ||
| // --chain=collectives-westend-dev | ||
| // --steps=2 | ||
| // --repeat=2 |
There was a problem hiding this comment.
Sure need to be re-generated before the next release.
system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
Ser @xlc, maybe another pass? |
|
/merge |
fellowship-merge-bot
bot
merged commit 49a04e5
into
polkadot-fellows:main
|
Enabled Available commands
For more information see the documentation |
…oded numbers usage for indexes (#182) This PR solves older TODO + addresses #109 (comment). <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [X] Does not require a CHANGELOG entry --------- Co-authored-by: Bastian Köcher <[email protected]>
Treasury Pallet Instance for the Fellowship in Polkadot Collectives.
In this update, we present a Treasury Pallet Instance that is under the control of the Fellowship body, with oversight from the Root and Treasurer origins. Here's how it is governed:
Additionally, we introduce the Asset Rate Pallet Instance to establish conversion rates from asset A to B. This is used to determine if a proposed spend amount involving a non-native asset is permissible by the commanding origin. The rates can be set up by the Root, Treasurer origins, or Voice of all Fellows.
test with xcm-emulator for the same setup in Westend - paritytech/polkadot-sdk#2532
more details on new treasury features and asset rate pallet - paritytech/polkadot-sdk#1333