Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDK stable2409-1 #490

Merged

Conversation

pandres95
Copy link
Contributor

@pandres95 pandres95 commented Oct 19, 2024

Closes #457
Closes #469

Updating the runtimes to SDK version stable2409-1. CHANGELOG mentions all relevant changes for UI and Walletbuilders.

Checklist

  • Update SDK to stable2409
  • Update configuration for relay chains.
  • Update configuration for system parachains.
  • Update configuration for emulated chains.
  • Update configuration for Encointer (see Help wanted).
  • Update CHANGELOG.
  • Update SDK to stable2409-1

Dependencies

This PR depends on certain PRs to be merged before it can properly work.

Impacts

The success of this PR impacts directly on the feasibility of executing certain issues, or closing certain PRs.

Help wanted

Initially, I request the help of:

  • @franciscoaguirre to help me correcting the potential conflicts that may arise when foreign assets change to XCMv4.
  • @acatangiu to help me setting up the Bridge Hubs, as well as adding the respective transition layer (a.k.a. preparing the migrations from fixed Lanes to LegacyLane-based lanes storage).
  • @clangenb to help me upgrading Encointer.
  • @Szegoo to check the parameters that changed in Coretime.

Sorry, something went wrong.

@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 2e8844d to 471ce8d Compare October 19, 2024 17:06
@pandres95 pandres95 changed the title Upgrade to Polkadot SDK stable2409 Update to Polkadot SDK stable2409 Oct 19, 2024
@pandres95 pandres95 changed the title Update to Polkadot SDK stable2409 Update to SDK stable2409 Oct 19, 2024
@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch 3 times, most recently from f08d159 to 4b4a252 Compare October 21, 2024 02:23
- Rename `assigner_on_demand` to `on_demand` (SDK #4706)
- [BEEFY] Add runtime support for reporting fork voting (#4522)
- `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives`
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- Mock Weights
- Rename `assigner_on_demand` to `on_demand` (SDK #4706)
- [BEEFY] Add runtime support for reporting fork voting (SDK #4522)
- `SchedulerParams` moved from `polkadot_primitives::vstaging`, to `polkadot_primitives`
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- Mock Weights
- [Assets] Call implementation for `transfer_all` (SDK #4527)
- [bridges-v2] Permissionless lanes (SDK #4949)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488)
- relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- [Assets] Call implementation for `transfer_all` (SDK #4527)
- [bridges-v2] Permissionless lanes (SDK #4949)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Tx Payment: drop ED requirements for tx payments with exchangeable asset (SDK #4488)
- relax XcmFeeToAccount trait bound on AccountId (SDK #4959)
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935)
- [bridges-v2] Permissionless lanes (SDK #4949)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Transfer Polkadot-native assets to Ethereum (SDK #5546)
- [stable2049] Backport #5546 (SDK #5710)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- Bridges V2 refactoring backport and pallet_bridge_messages simplifications (SDK #4935)
- [bridges-v2] Permissionless lanes (SDK #4949)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Transfer Polkadot-native assets to Ethereum (SDK #5546)
- [stable2049] Backport #5546 (SDK #5710)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- [bh polkadot] minor: replace `DOLLARS` with `UNITS` on `BridgeDeposit` storage type
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Coretime auto-renew (SDK #4424)
- Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- Coretime auto-renew (SDK #4424)
- Mock Weights
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- `XcmFeeToAccount` -> `SendXcmFeeToAccount`
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
- add possibility to inject non-authorities session-keys in genesis (SDK #5078)
@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 3d0b758 to e0760ad Compare October 21, 2024 02:45
@pandres95 pandres95 marked this pull request as ready for review October 21, 2024 07:38
@clangenb
Copy link
Contributor

I can probably squeeze it in later this week. 👍

@pandres95
Copy link
Contributor Author

Opened for review with a small caveat: tests will keep failing, until #472 is merged and can be merged back to this branch.

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs Outdated Show resolved Hide resolved
relay/polkadot/src/lib.rs Outdated Show resolved Hide resolved
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
@anaelleltd
Copy link
Collaborator

To reviewers:
Please take care to double check this update carefully and advise if there are potential breaking changes or disruptions for ecosystem builders.
If any, please ping @anaelleltd or @SBalaguer in your detailed commentary so that we can notify ecosystem teams with the critical information.

Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial feedback, still not finished

relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
relay/polkadot/src/lib.rs Outdated Show resolved Hide resolved
Ank4n and others added 2 commits November 21, 2024 21:27
* revert delegate stake configuration in kusama

* update pool migrating max count
* Remove unused

* Added `LocalXcmChannelManager` for bridges

* Fixed `BridgeDeposit` TODO

* Compilation fix + don't need to fund system para

* fmt
@bkchr
Copy link
Contributor

bkchr commented Dec 8, 2024

@pandres95 can we go ahead with merging?

@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch 3 times, most recently from d80c747 to 21ab960 Compare December 9, 2024 03:48
@pandres95
Copy link
Contributor Author

bot fmt

@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch from 21ab960 to 0371b42 Compare December 9, 2024 04:16
@pandres95
Copy link
Contributor Author

@bkchr yes!

I can open another PR later this week to upgrade to stable2409-3 and address the fixes @bkontur and @seadanda are waiting for from that patch.

Note: A test called next_inflation is failing right now. But it's highly likely that it's due to a connection issue with the RPC endpoint stated here (note that it's trying to connect to wss://rpc.dotters.network/kusama, which works on my machine™ BTW).

@pandres95 pandres95 force-pushed the upgrade-polkadot-stable2409 branch from b63bc44 to 1e57a18 Compare December 12, 2024 00:33
@pandres95
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 7b096c1 into polkadot-fellows:main Dec 12, 2024
48 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@pandres95 pandres95 deleted the upgrade-polkadot-stable2409 branch December 12, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to polkadot sdk stable2409 chore: upgrade to polkadot sdk stable2407