Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[encointer] fix missing hook for enactment of proposals #508

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Dec 9, 2024

The first 4 Encointer democracy proposals have been up for vote and two proposals have been approved. However, we realized that enactment did not happen. This is due to a missing hook in the runtime.

This PR should fix the hook and enact the already approved after the next runtime upgrade when the cycle phase changes to "assigning"

@brenzi brenzi force-pushed the ab/fix-onceremony-phasechange branch from 8c90492 to bfed478 Compare December 9, 2024 19:14
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be worth an e2e test, won't block though

@brenzi
Copy link
Contributor Author

brenzi commented Dec 14, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) December 14, 2024 09:36
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants