Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello @lavrton, #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nkrider7
Copy link

Please review my pull request. I've added a "Save File" button with the option to customize the file name. I found that every time we save a file in Polotno Studio, it's automatically named "polotno.json." I've worked on changing this behavior to allow for custom file names. Your feedback on this change is greatly appreciated.

Thank you for your time and assistance!

Please review my pull request. I've added a "Save File" button with the option to customize the file name. I found that every time we save a file in Polotno Studio, it's automatically named "polotno.json." I've worked on changing this behavior to allow for custom file names. Your feedback on this change is greatly appreciated.

Thank you for your time and assistance!
@netlify
Copy link

netlify bot commented Oct 17, 2023

‼️ Deploy request for polotno-studio rejected.

Name Link
🔨 Latest commit 7695297

@lavrton
Copy link
Collaborator

lavrton commented Oct 17, 2023

Hello. That is a good request. But what if we will generate filename based on the content, like we do for image saving?

https://github.com/polotno-project/polotno-studio/blob/master/src/topbar/download-button.js#L23-L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants