Add indexes to MonetDB #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are still advisory, but at least we advise MonetDB.
|
I have changed the index Name and Display Text to "ADVISORY ONLY" to make it clear to the user that the index is advisory only. Can you please check why the index method names are not displayed in the UI? This makes it impossible to create an index from the UI. |
vogti
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the MonetDB documentation,
CREATE INDEXstatements are treated as advice only. Because of this it was previously it was an error to create an index on a MonetDB store. With this PR this is not longer an error and we execute an appropriateCREATE INDEXstatement on the MonetDB store (although MonetDB may treat it as advisory and ignore it).