feat: add rust app codegen template #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niraj-Kamdar
requested review from
dOrgJelli,
krisbitney,
nerfZael,
cbrzn and
namesty
as code owners
Niraj-Kamdar
changed the title
Niraj-Kamdar
force-pushed
the
nk/add-rs-app-template
branch
from
e25d838
to
14d4ce2
Compare
dOrgJelli
previously approved these changes
Aug 30, 2023
dOrgJelli
previously approved these changes
Aug 31, 2023
cbrzn
reviewed
Sep 1, 2023
| "ipfs:down": "npx polywrap infra down --modules=eth-ens-ipfs" | ||
| }, | ||
| "dependencies": { | ||
| "@polywrap/client-js": "~0.12.0" |
There was a problem hiding this comment.
we can also remove this one right
| }, | ||
| "devDependencies": { | ||
| "@types/node": "18.15.0", | ||
| "polywrap": "0.11.2", |
dOrgJelli
requested changes
Sep 1, 2023
packages/templates/app/rust/.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| v17.9.1 | |||
There was a problem hiding this comment.
Should be v18.15.0 like all other .nvmrc files in the CLI repo
| @@ -0,0 +1,17 @@ | |||
| [package] | |||
| name = "template_plugin_rs" | |||
There was a problem hiding this comment.
should be "template_app_rs"
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "name": "templates-app-rust", | |||
| "description": "Polywrap App Rust Template", | |||
There was a problem hiding this comment.
No need for name, description, version
| "scripts": { | ||
| "build": "npx polywrap codegen", | ||
| "test": "ts-node ./src/index.ts", | ||
| "ipfs:up": "npx polywrap infra up --modules=eth-ens-ipfs", |
There was a problem hiding this comment.
Forget to remove! before I was using local ipfs in template but then migrate to just cat instead of add and cat
| "version": "0.11.2", | ||
| "scripts": { | ||
| "build": "npx polywrap codegen", | ||
| "test": "ts-node ./src/index.ts", |
| @@ -0,0 +1,30 @@ | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.