-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Markdown in comments #199
add support for Markdown in comments #199
Conversation
I didn't know there's an easy way to support Markdown in comments, awesome! Still, well tested or not, I won't let PR in without tests. Please add one or two. |
Sure! |
Btw, if you want to contribute more, documentation comments support needs some attention. It's broken/unsupported for some language items, and uses old API. |
Yep, I have already noticed some problems with the documentation |
Added several tests for the most commonly used markup constructs |
Does the plugin needs to be dependent on the Markdown plugin now? |
@mkurnikov looks like you need to approve every workflow 😞 |
it works without it but let me check it for sure |
since it's bundled it should work fine I think |
I'll see what I can do. For now, I guess I'd just do it manually.
Got it, no problem then. |
Works fine even in IDEA Community |
Great work, thanks! One last bit: |
Yep |
@mkurnikov added some documentation, hopefully this code makes a little more sense now |
3d5b365
to
3a16b36
Compare
Hey! This PR adds support for Markdown in doc comments.
Currently it looks like this:
Before
With this changes:
After
Screen.Recording.2024-10-18.at.01.37.20.mov
Please note that this code is taken from my internal language plugin and is well tested.