Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse clicks not properly delivered when in Global workspace mode #161

Closed
Tracked by #194
jackpot51 opened this issue Sep 7, 2023 · 4 comments · Fixed by #172 or #194
Closed
Tracked by #194

Mouse clicks not properly delivered when in Global workspace mode #161

jackpot51 opened this issue Sep 7, 2023 · 4 comments · Fixed by #172 or #194
Assignees

Comments

@jackpot51
Copy link
Member

In Global workspaces mode, with three monitors arranged horizontally, I often cannot click on controls on windows that are on the second and third monitor.

@jackpot51 jackpot51 self-assigned this Sep 7, 2023
@Drakulix
Copy link
Member

Drakulix commented Sep 8, 2023

Oh fun, I wonder what broke this, as this definitely used to work...

This function should translate from global coordinates to workspace-relative coordinates. Which should be the same coordinate space, in global-workspace-mode, which makes the issue more perplexing. For output-local-workspaces the translating basically remaps the event to be relative to the output.

I guess somewhere we are missing this translation call..

ids1024 added a commit that referenced this issue Sep 13, 2023
I didn't see any issue with how mouse events were handled, but a bisect
showed b818a68 caused the issue.
Reverting the definition of `element_under` to the version before that
change

Comparing what both versions return, the right element is returned, but
the location returned is wrong. This makes the return value match the
position that was returned by the previous implementation. It seems to
be working correctly now.

Fixes #161.
ids1024 added a commit that referenced this issue Sep 13, 2023
I didn't see any issue with how mouse events were handled, but a bisect
showed b818a68 caused the issue.
Reverting the definition of `element_under` to the version before that
change fixed the behavior.

Comparing what both versions return, the right element is returned, but
the location returned is wrong. This makes the return value match the
position that was returned by the previous implementation. It seems to
be working correctly now.

Fixes #161.
ids1024 added a commit that referenced this issue Sep 13, 2023
I didn't see any issue with how mouse events were handled, but a bisect
showed b818a68 caused the issue.
Reverting the definition of `element_under` to the version before that
change fixed the behavior.

Comparing what both versions return, the right element is returned, but
the location returned is wrong. This makes the return value match the
position that was returned by the previous implementation. It seems to
be working correctly now.

Fixes #161.
@ids1024
Copy link
Member

ids1024 commented Sep 13, 2023

Took a while to track it down, but #172 seems to fix this.

@jackpot51
Copy link
Member Author

This is still an issue for the cosmic panel, if it is running on the middle display in a three display setup.

@jackpot51
Copy link
Member Author

Re-opening, since the cosmic panel is not receiving mouse clicks when on the middle display in a three display setup, while using Global worskpace mode.

@jackpot51 jackpot51 reopened this Sep 28, 2023
@Drakulix Drakulix mentioned this issue Oct 10, 2023
18 tasks
@Drakulix Drakulix linked a pull request Oct 11, 2023 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants