Fix TilingLayout::element_under position with global workspaces
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't see any issue with how mouse events were handled, but a bisect showed b818a68 caused the issue. Reverting the definition of `element_under` to the version before that change fixed the behavior. Comparing what both versions return, the right element is returned, but the location returned is wrong. This makes the return value match the position that was returned by the previous implementation. It seems to be working correctly now. Fixes #161.
Drakulix
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see any issue with how mouse events were handled, but a bisect showed b818a68 caused the issue. Reverting the definition of
element_underto the version before that change fixed the behavior.Comparing what both versions return, the right element is returned, but the location returned is wrong. This makes the return value match the position that was returned by the previous implementation. It seems to be working correctly now.
Fixes #161.