main: Update D-Bus activation environment also on non-systemd systems #1038
Conversation
On systems without systemd, use zbus to update D-Bus activation environment with `WAYLAND_DISPLAY` and `DISPLAY` variables. Fixes pop-os#1037
| if let state::BackendData::Kms(_) = &self.backend { | ||
| #[cfg(feature = "systemd")] | ||
| systemd::ready(&self.common); |
There was a problem hiding this comment.
I was thinking about replacing the systemd::ready entirely with dbus::ready, I think that should work as well. What's good about the dbus solution is not calling external binaries. For now I didn't remove systemd::ready in case you consider that too intrusive. I would love to hear your thoughts here.
What I can confirm is that this patch fixes flatpak Steam on my Gentoo+openrc installation.
There was a problem hiding this comment.
The systemd environment is still something separate from the dbus environment, the dbus-broker just happens to import it on systems with systemd.
Just updating the dbus activation environment would this break e.g. systemd user services. I think this is a sensible solution. If calling external binaries would really be a problem, we could also trigger the systemd interface via dbus, but given this is a one time startup thing, I wouldn't bother.
There was a problem hiding this comment.
Makes sense, thanks!
| if let state::BackendData::Kms(_) = &self.backend { | ||
| #[cfg(feature = "systemd")] | ||
| systemd::ready(&self.common); |
There was a problem hiding this comment.
The systemd environment is still something separate from the dbus environment, the dbus-broker just happens to import it on systems with systemd.
Just updating the dbus activation environment would this break e.g. systemd user services. I think this is a sensible solution. If calling external binaries would really be a problem, we could also trigger the systemd interface via dbus, but given this is a one time startup thing, I wouldn't bother.
On systems without systemd, use zbus to update D-Bus activation environment with
WAYLAND_DISPLAYandDISPLAYvariables.Fixes #1037