wayland: map windows with correct geometry #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a simple client that doesn't use set_window_geometry, committing after attaching a buffer to a window surface. Window::geometry falls back to Window::bbox, but when Shell::map_window called Window::geometry, Window::bbox hadn't been set yet, because that only happened later in <State as CompositorHandler>::commit, so the window would be mapped with a size of (0, 0). This resulted in server-side decorations not being drawn for such clients until they were re-focused or resized. The fix is to add an extra call to Window::on_commit() before mapping it, so that its bbox is set correctly when Shell::map_window asks for its geometry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a simple client that doesn't use
set_window_geometry, committing after attaching a buffer to a window surface.Window::geometryfalls back toWindow::bbox, but whenShell::map_windowcalledWindow::geometry,Window::bboxhadn't been set yet, because that only happened later in<State as CompositorHandler>::commit, so the window would be mapped with a size of (0, 0).This resulted in server-side decorations not being drawn for such clients until they were re-focused or resized.
The fix is to add an extra call to
Window::on_commitbefore mapping it, so that its bbox is set correctly whenShell::map_windowasks for its geometry.