Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NextOutput and PreviousOutput when Shell::activate returns None #184

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

jackpot51
Copy link
Member

This fixes #160, but I am not sure when Shell::activate is supposed to return a position versus when it is not.

@jackpot51 jackpot51 requested a review from Drakulix September 28, 2023 19:22
@jackpot51 jackpot51 self-assigned this Sep 28, 2023
@jackpot51
Copy link
Member Author

When using the focus shortcuts, this activates whatever window was last active on that output, not the window in the focus direction. Fixing this probably requires not falling back to next/previous output in the focus shortcuts.

@Drakulix
Copy link
Member

Shell::activate is supposed to return a position versus when it is not.

The position is used to actually move the cursor to the new output (which can't happen inside the Shell module).
So this sounds more like an oversight to be, that Shell::activate is not returning a position, when it is clearly switching outputs and not just a workspace on the same output.

I'll merge this for the meantime though, as I am rewriting large parts of the workspace-managing code in shell/mod.rs anyway, which should also fix this issue.

Fixing this probably requires not falling back to next/previous output in the focus shortcuts.

Yes.

@Drakulix Drakulix merged commit 0b057f1 into master_jammy Sep 29, 2023
1 check passed
@jackpot51 jackpot51 deleted the focus-across-monitors_jammy branch September 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus switching shortcuts do not traverse monitors
2 participants