Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ext-session-lock protocol #203

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add ext-session-lock protocol #203

merged 1 commit into from
Oct 27, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Oct 25, 2023

This is now usable, though some details may need to be adjusted.

Drakulix
Drakulix reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first draft, disregarding the couple of TODOs still in there.

src/backend/winit.rs Outdated Show resolved Hide resolved
src/input/mod.rs Outdated Show resolved Hide resolved
src/input/mod.rs Show resolved Hide resolved
@ids1024 ids1024 force-pushed the session-lock_jammy branch 3 times, most recently from 49cd558 to 6b2066f Compare October 26, 2023 17:34
@Drakulix Drakulix changed the base branch from ws-refactor_jammy to master_jammy October 26, 2023 17:42
@ids1024 ids1024 force-pushed the session-lock_jammy branch 3 times, most recently from 37930cd to 62da2d9 Compare October 26, 2023 19:24
@ids1024 ids1024 marked this pull request as ready for review October 26, 2023 19:28
@ids1024 ids1024 mentioned this pull request Oct 27, 2023
Merged
Drakulix
Drakulix approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! One little nitpick.

src/state.rs Show resolved Hide resolved
@Vixea Vixea mentioned this pull request Oct 27, 2023
Merged
3 tasks
@ids1024 ids1024 force-pushed the session-lock_jammy branch from 62da2d9 to f0277ea Compare October 27, 2023 16:01
@Drakulix Drakulix merged commit 25f5edd into master_jammy Oct 27, 2023
1 check passed
@Drakulix Drakulix deleted the session-lock_jammy branch October 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ids1024 @Drakulix