Fix handling of layer shell surface with exclusive interactivity #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should now match the protocol specification, and how Sway behaves. If a surface in the `Top` or `Overlay` has `KeyboardInteractivity::Exclusive`, only that surface can have keyboard focus. If multiple surfaces do, focus can be changed between those with keyboard exclusivity on the highest layer. This is similar to session lock surfaces, except a session lock takes precedence. This fixes the behavior of keyboard focus in `cosmic-greeter`, with the current layer-shell based implementation.
ids1024
force-pushed
the
exclusive-keyboard_jammy
branch
from
053c7a8 to
3bec008
Compare
Drakulix
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now match the protocol specification, and how Sway behaves.
If a surface in the
ToporOverlayhasKeyboardInteractivity::Exclusive, only that surface can have keyboard focus. If multiple surfaces do, focus can be changed between those with keyboard exclusivity on the highest layer.This is similar to session lock surfaces, except a session lock takes precedence.
This fixes the behavior of keyboard focus in
cosmic-greeter, with the current layer-shell based implementation.