cosmic: Provide CosmicConfigEntry impl, use _ in property names
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to derive `CosmicConfigEntry`, we need to use `_` in property names, because `_` isn't mapped to `-` and there doesn't seem to be a mechanism like `#[serde(rename)]`. It seems good to be consistent anyway. So this seems good to change, unless we really like using `-` for names on disk, then cosmic-panel needs to be changed. `CosmicConfigEntry` also requires `PartialEq`, which is easy enough to add. This will break existing input settings, which will have to be re-applied with the new locations. Cosmic-settings also need to be updated for this.
Drakulix
approved these changes
Dec 21, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to derive
CosmicConfigEntry, we need to use_in property names, because_isn't mapped to-and there doesn't seem to be a mechanism like#[serde(rename)].It seems good to be consistent anyway. So this seems good to change, unless we really like using
-for names on disk, then cosmic-panel needs to be changed.CosmicConfigEntryalso requiresPartialEq, which is easy enough to add.This will break existing input settings, which will have to be re-applied with the new locations. Cosmic-settings also need to be updated for this.