Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating: Maximize animation #269

Merged
merged 2 commits into from
Jan 29, 2024
Merged

floating: Maximize animation #269

merged 2 commits into from
Jan 29, 2024

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Jan 5, 2024

And a bunch of fixes for geometry restoring in floating mode.

@Drakulix Drakulix force-pushed the maximize-anim_jammy branch from 1c47b30 to 73e459d Compare January 26, 2024 16:42
@Drakulix Drakulix force-pushed the maximize-anim_jammy branch from 73e459d to 9da41d4 Compare January 26, 2024 16:45
@wash2
Copy link
Contributor

wash2 commented Jan 26, 2024

This seems mostly good, but for some reason I see a compositor panic when I maximize a window in tiling mode, then switch to window mode, unmaximizing the window, and then drag the window.

@wash2
Copy link
Contributor

wash2 commented Jan 26, 2024

thread 'main' panicked at 'assertion failed: was_floating != was_tiled.is_some()': src/shell/mod.rs:2292

@Drakulix Drakulix force-pushed the maximize-anim_jammy branch from ad0243a to 8804a7c Compare January 26, 2024 18:52
@Drakulix
Copy link
Member Author

This seems mostly good, but for some reason I see a compositor panic when I maximize a window in tiling mode, then switch to window mode, unmaximizing the window, and then drag the window.

I assume "window mode" should have been "floating mode". I can't reproduce it with the last commit anymore, can you verify? Basically I think what has happened was switching to "floating mode" removed the window from the tiling_layer and added it to the floating, unmaximizing restored the previous state, so it re-added the window to the tiling layer and then the check breaks as the window is mapped twice (which should never happen).

I added a check if tiling-mode is still enabled to all cases, where we map stuff to the tiling_layer later again.

@Drakulix Drakulix merged commit ce74675 into master_jammy Jan 29, 2024
4 checks passed
@jackpot51 jackpot51 deleted the maximize-anim_jammy branch January 30, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants