Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow access to ListColumn on Section #599

Merged

Conversation

acolombier
Copy link
Contributor

Add an helper method to edit Section's ListColumn properties on the fly

Used in pop-os/cosmic-settings#557

@mmstick
Copy link
Member

mmstick commented Sep 6, 2024

I think it'd be better to have a function for passing an existing ListColumn into a new Section

@acolombier acolombier force-pushed the feat/allow-listcolumn-update-on-section branch from 2a0ba80 to 4139875 Compare September 7, 2024 11:08
@acolombier
Copy link
Contributor Author

Updated as suggested!

@acolombier acolombier force-pushed the feat/allow-listcolumn-update-on-section branch 2 times, most recently from cb0061f to a038604 Compare September 14, 2024 11:59
@mmstick mmstick force-pushed the feat/allow-listcolumn-update-on-section branch from a038604 to b94a511 Compare September 19, 2024 12:30
Copy link
Member

@mmstick mmstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mmstick mmstick merged commit af68a3f into pop-os:master Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants