Don't create new screencopy session or wl_buffer each frame #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Session` type now contains a reference to the `ZCosmicScreencopySessionV1`, and is reference counted internally. `SessionData` now uses a weak reference to `Session`, and the wayland object is destroyed when the strong references are all dropped. This should help for re-using the screencopy session, and moving to v2 of cosmic screencopy. Later this logic should be combined with the screencopy code in cosmic-workspaces to have a higher-level abstraction that can be used in both.
It still should also avoid creating a new `wl_buffer` each frame.
Not compatible with re-use of of screencopy session.
Now we create a `wl_buffer` in the pipewire `add_buffer` handler, and store it in the `pw_buffer` user data. And destroy the buffer in the `remove_buffer` handler. `pipewire-rs` still needs more safe APIs for `pw_buffer`, but this is alright.
wash2
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't change behavior, except that
WAYLAND_DEBUG=1will show a lot fewer Wayland requests while capturing the screen. And perhaps some performance benefit, but I haven't specifically verified that.The changes to how screencopy is handled should help for moving to the v2 screencopy protocol (pop-os/cosmic-protocols#24).