Made Cursor Show By Default If Client Doesn't Request The Cursor Mode #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec seems to say the default should be "hidden", as implemented here already? https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.impl.portal.ScreenCast.html
|
|
Even if it is the default on the spec, no user expects it to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within most DEs/WMs, the default handling of cursors when using the ScreenCast protocol is that if the client does not request any, it defaults to showing the cursor.
Currently, Cosmic is not doing that, causing the cursor to not appear on apps which do not implement this part of the spec (such as Chromium) causing the cursor to be missing when screen sharing.
This is a simple one-line PR just to change the defaults so the cursor can be seen :)